Skip to content

[MAX32625PICO] Add new platform #6779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from May 11, 2018
Merged

[MAX32625PICO] Add new platform #6779

merged 3 commits into from May 11, 2018

Conversation

khariya
Copy link
Contributor

@khariya khariya commented Apr 30, 2018

Depends on PR #6778

Description

MAX32625PICO is available with and without Bootloader.
Use target name MAX32625PICO_NO_BOOT to compile without the bootloader.
Use target name MAX32625PICO to compile with the bootloader.

Test results:
mbed_test_max32625pico-no-boot_arm.txt
mbed_test_max32625pico-no-boot_gcc-arm.txt
mbed_test_max32625pico-no-boot_iar.txt

Tested all supported toolchains with MAX32625PICO

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

0xc0170
0xc0170 previously approved these changes May 2, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 2, 2018

Build : SUCCESS

Build number : 1889
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6779/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 2, 2018

@mbed-ci
Copy link

mbed-ci commented May 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

/morph mbed2-build
/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

@khariya Please resolve the conflict

Keyur Hariya added 2 commits May 3, 2018 10:57
This platform is available with or without Bootloader.
@khariya
Copy link
Contributor Author

khariya commented May 3, 2018

Conflict resolved. Rebased with the master branch.

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

@cmonr cmonr requested a review from ashok-rao May 7, 2018 15:53
@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1933
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6779/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@ashok-rao
Copy link
Contributor

@khariya , for the target with the bootloader, are there any post build steps required to "combine" the bootloader with the generated binary?

SPI2_MOSI = P2_5,
SPI2_MISO = P2_6,
SPI2_SS = P2_7,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khariya : Since there are multiple peripherals of each type, it would be recommended to define a "default" for each one.. for ex: SPI_MOSI = SPI1_MOSI , I2C_SDA = I2C1_SDA & so on.. so that application code doesn't need to explicitly specify the peripheral number to use..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashok-rao Added the default defines. Thanks.

@khariya
Copy link
Contributor Author

khariya commented May 7, 2018

@ashok-rao No additional post-build steps are required for the target with the bootloader, the generated binary is sufficient.
Please note that the bootloader must be programmed separately before dropping the application binary. Compiling the target with bootloader does not combine the bootloader with the application.

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2018

Restarting CI. The last commit looks fine.

/morph build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

Build : SUCCESS

Build number : 1942
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6779/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@ashok-rao
Copy link
Contributor

Thanks @khariya for adding the defaults. Regarding bootloader, curious to know how this will be made available to end users? Will there be a link somewhere on the platform page?

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

/morph mbed2-build

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

/morph mbed2-build

@khariya
Copy link
Contributor Author

khariya commented May 8, 2018

@ashok-rao The MAX32625PICO board(as a target, not as a programmer) comes with the bootloader installed on it by default.
Thanks.

@cmonr
Copy link
Contributor

cmonr commented May 9, 2018

/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented May 9, 2018

@ashok-rao Does this link answer your question? https://os.mbed.com/platforms/MAX32625PICO/#default-daplink-image

@khariya Is it expected that this link will be updated when updates are needed/available?

@ashok-rao
Copy link
Contributor

ashok-rao commented May 10, 2018

Thanks for the link @cmonr . All other changes good to go from my side.
@khariya : can we have the default bootloader binary provided to users from that link as well? or steps/ link to update it when there are updates to it in the future.. along with DAPlink as already provided.. thanks.

Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @khariya

@cmonr
Copy link
Contributor

cmonr commented May 10, 2018

@khariya I'm ready to give the ok and get this merged in once we get the last couple of questions answered.

@khariya
Copy link
Contributor Author

khariya commented May 10, 2018

@cmonr @ashok-rao The platform page will be updated when needed.
We can provide the default bootloader binary on the platform page along with instructions. Additional hardware will be required to update the bootloader.

@ashok-rao
Copy link
Contributor

thanks @khariya . Please update the instructions on the platform page along with any specific HW / SW requirements. Thanks.

@khariya
Copy link
Contributor Author

khariya commented May 10, 2018

Yes, I will update the platform page. Thanks!

@cmonr cmonr merged commit 4318caa into ARMmbed:master May 11, 2018
@khariya khariya deleted the add-max32625pico branch May 11, 2018 15:36
@adbridge
Copy link
Contributor

There is something very strange in the commit history for this PR. Trying to cherry pick across to 5.8 we get the following:

error: patch failed: targets/TARGET_Maxim/TARGET_MAX32625/device/TOOLCHAIN_IAR/TARGET_MAX32625MBED/MAX32625.icf:1
error: targets/TARGET_Maxim/TARGET_MAX32625/device/TOOLCHAIN_IAR/TARGET_MAX32625MBED/MAX32625.icf: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.

As I can't see an easy way of fixing this I'm going to push it out to 5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants