-
Notifications
You must be signed in to change notification settings - Fork 3k
[MAX32625PICO] Add new platform #6779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : SUCCESSBuild number : 1889 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1537 |
Test : FAILUREBuild number : 1706 |
/morph mbed2-build |
/morph test |
@khariya Please resolve the conflict |
This platform is available with or without Bootloader.
Conflict resolved. Rebased with the master branch. |
Test : FAILUREBuild number : 1717 |
/morph build |
Build : SUCCESSBuild number : 1933 Triggering tests/morph test |
@khariya , for the target with the bootloader, are there any post build steps required to "combine" the bootloader with the generated binary? |
SPI2_MOSI = P2_5, | ||
SPI2_MISO = P2_6, | ||
SPI2_SS = P2_7, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khariya : Since there are multiple peripherals of each type, it would be recommended to define a "default" for each one.. for ex: SPI_MOSI = SPI1_MOSI , I2C_SDA = I2C1_SDA & so on.. so that application code doesn't need to explicitly specify the peripheral number to use..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashok-rao Added the default defines. Thanks.
@ashok-rao No additional post-build steps are required for the target with the bootloader, the generated binary is sufficient. |
Test : SUCCESSBuild number : 1755 |
Exporter Build : SUCCESSBuild number : 1579 |
Restarting CI. The last commit looks fine. /morph build |
Build : SUCCESSBuild number : 1942 Triggering tests/morph test |
Thanks @khariya for adding the defaults. Regarding bootloader, curious to know how this will be made available to end users? Will there be a link somewhere on the platform page? |
Test : SUCCESSBuild number : 1764 |
Exporter Build : SUCCESSBuild number : 1592 |
/morph mbed2-build |
1 similar comment
/morph mbed2-build |
@ashok-rao The MAX32625PICO board(as a target, not as a programmer) comes with the bootloader installed on it by default. |
/morph mbed2-build |
@ashok-rao Does this link answer your question? https://os.mbed.com/platforms/MAX32625PICO/#default-daplink-image @khariya Is it expected that this link will be updated when updates are needed/available? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @khariya
@khariya I'm ready to give the ok and get this merged in once we get the last couple of questions answered. |
@cmonr @ashok-rao The platform page will be updated when needed. |
thanks @khariya . Please update the instructions on the platform page along with any specific HW / SW requirements. Thanks. |
Yes, I will update the platform page. Thanks! |
There is something very strange in the commit history for this PR. Trying to cherry pick across to 5.8 we get the following:
As I can't see an easy way of fixing this I'm going to push it out to 5.9. |
Depends on PR #6778
Description
MAX32625PICO is available with and without Bootloader.
Use target name MAX32625PICO_NO_BOOT to compile without the bootloader.
Use target name MAX32625PICO to compile with the bootloader.
Test results:
mbed_test_max32625pico-no-boot_arm.txt
mbed_test_max32625pico-no-boot_gcc-arm.txt
mbed_test_max32625pico-no-boot_iar.txt
Tested all supported toolchains with MAX32625PICO
Pull request type