Add POSIX fcntl flag support #6791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no way to check current blocking state, so no way to modify and restore status. Also have default FileHandle::set_blocking() used by real files return a correct error code when asked for non-blocking, and success when asked for blocking. These were minor omissions that are required to implement POSIX fcntl properly. fixup! Add `is_blocking()` method to FileHandle
Avoid using `fh` for the integer descriptor numbers, reserving that for the `FileHandle` objects - use `fildes` or `fd`, matching POSIX.
Add the POSIX fcntl call, but only implementing F_SETFL and F_GETFL
for O_NONBLOCK, so users can control the blocking flag of streams
with only the integer file descriptor.
Necessary to portably control the blockingness of the console:
int flags = fcntl(STDOUT_FILENO, F_GETFL);
fcntl(STDOUT_FILENO, F_SETFL, flags | O_NONBLOCK);
0xc0170
approved these changes
May 4, 2018
|
Going to get the build started, but could really use feedback from @geky and @SenRamakri /morph build |
Build : SUCCESSBuild number : 1940 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1587 |
Test : SUCCESSBuild number : 1762 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 1591 |
geky
approved these changes
May 8, 2018
SenRamakri
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
POSIX functions added back in #5571 had one omission -
fcntl, which could be used to control non-blocking. Add enoughfcntlto do this manipulation. This may be useful in particular to do non-blocking control trickery onSTDOUT_FILENO.We could also add a method to convert integer file descriptor to
FileHandle, but this change is useful to permit portable POSIX code.Pull request type