Skip to content

tools: Reorder test configuration priority #6805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

The mbed test subcommand Takes two arguments, --app-config and
--test-config. The test config parameter takes priority over the
app config parameter. Where things get weird is after that:
The current order (before this PR):

  • --test-config
  • --app-config
  • test config (as defined in test_config)
  • mbed_app.json in root.

That's probably because we did not have a good way to do what this PR
does:

  • --test-config
  • --app-config
  • mbed_app.json in root.
  • test config (as defined in test_config):

This gives the user more control and matches the documented behavior in
the arguments

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Old order:
 * --test-config
 * --app-config
 * test config (as defined in test_config)
 * `mbed_app.json` in root.

New order:
 * --test-config
 * --app-config
 * `mbed_app.json` in root.
 * test config (as defined in test_config)~

This matches the documentation and user expectation
@0xc0170 0xc0170 changed the title tools: Reorder test configuration proirity tools: Reorder test configuration priority May 4, 2018
@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1931
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6805/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants