-
Notifications
You must be signed in to change notification settings - Fork 3k
GenericSecurityManager: Fix crypto_toolbox_f4 signature. #6817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericSecurityManager: Fix crypto_toolbox_f4 signature. #6817
Conversation
The type exposed in the header file were not aligned to the one used in the implementation: ble::public_key_t instead of ble::public_key_coord_t.
@marcuschangarm @donatieng Could you review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The Cloud client compiles now!
/morph build |
Build : SUCCESSBuild number : 1935 Triggering tests/morph test |
Test : SUCCESSBuild number : 1757 |
Exporter Build : FAILUREBuild number : 1581 |
Looks like a machine left too soon. /morph export-build |
Exporter Build : FAILUREBuild number : 1589 |
This is irritating... More Java IO Exceptions.
/morph export-build |
Exporter Build : FAILUREBuild number : 1597 |
Restarting again since modifications to CI were made. |
Exporter Build : SUCCESSBuild number : 1603 |
Description
The type exposed in the header file were not aligned to the one used in
the implementation: ble::public_key_t instead of ble::public_key_coord_t.
This PR should fix #6760 .
Pull request type