Skip to content

GenericSecurityManager: Fix crypto_toolbox_f4 signature. #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2018

Conversation

pan-
Copy link
Member

@pan- pan- commented May 4, 2018

Description

The type exposed in the header file were not aligned to the one used in
the implementation: ble::public_key_t instead of ble::public_key_coord_t.

This PR should fix #6760 .

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

The type exposed in the header file were not aligned to the one used in
the implementation: ble::public_key_t instead of ble::public_key_coord_t.
@pan-
Copy link
Member Author

pan- commented May 4, 2018

@marcuschangarm @donatieng Could you review ?

Copy link
Contributor

@marcuschangarm marcuschangarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The Cloud client compiles now!

@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1935
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6817/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

Looks like a machine left too soon.

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

This is irritating...

More Java IO Exceptions.

05:32:22 FATAL: command execution failed
05:32:22 java.io.EOFException
05:32:22 	at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2675)
05:32:22 	at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3150)
05:32:22 	at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:859)
05:32:22 	at java.io.ObjectInputStream.<init>(ObjectInputStream.java:355)
05:32:22 	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:48)
05:32:22 	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
05:32:22 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
05:32:22 Caused: java.io.IOException: Unexpected termination of the channel
05:32:22 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

Restarting again since modifications to CI were made.
/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

@cmonr cmonr merged commit c97a8fb into ARMmbed:master May 9, 2018
@pan- pan- deleted the fix-crypto_toolbox_f4-parameter-types branch November 14, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type definition for public_key_t
6 participants