Skip to content

tools: Remove long-deprecated build_everything.py #6823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

This needs to happen, because it removes a small disincentive to improving
the build system: verifying that this script still works. This PR removes
this file and the disincentive.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from screamerbg May 7, 2018 09:43
@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

Is the reason that this file is long-deprecated because there are other tests that supercede it's functionality?

I took a look at its history, and found that the history is quite sparse. Is there any particular reason why other files that were a part of its original commit should not also be removed? (Ref: 0034ffb#diff-d1ccf7c14517be793178cf50b3203641)

@theotherjimmy
Copy link
Contributor Author

@cmonr That commit is a big pile of unrelated features. It's long-deprecated because it does not have a call in travis, mbed-cli, or any other CI and it sees no maintenance.

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

Starting a build to check something w/ the CI.
But also since this should be good but is still waiting on review.

/morph build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

Build : FAILURE

Build number : 1952
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6823/

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

Issues should be resolved.
/morph build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

Build : SUCCESS

Build number : 1956
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6823/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

@theotherjimmy
Copy link
Contributor Author

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr cmonr merged commit b165e9c into ARMmbed:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants