-
Notifications
You must be signed in to change notification settings - Fork 3k
tools: Remove long-deprecated build_everything.py #6823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's not used
Is the reason that this file is long-deprecated because there are other tests that supercede it's functionality? I took a look at its history, and found that the history is quite sparse. Is there any particular reason why other files that were a part of its original commit should not also be removed? (Ref: 0034ffb#diff-d1ccf7c14517be793178cf50b3203641) |
@cmonr That commit is a big pile of unrelated features. It's long-deprecated because it does not have a call in travis, mbed-cli, or any other CI and it sees no maintenance. |
Starting a build to check something w/ the CI. /morph build |
Build : FAILUREBuild number : 1952 |
Issues should be resolved. |
Build : SUCCESSBuild number : 1956 Triggering tests/morph test |
Test : SUCCESSBuild number : 1772 |
Exporter Build : FAILUREBuild number : 1606 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 1612 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This needs to happen, because it removes a small disincentive to improving
the build system: verifying that this script still works. This PR removes
this file and the disincentive.
Pull request type