-
Notifications
You must be signed in to change notification settings - Fork 3k
Check that no GPL licence inside code #6848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You will most probably need to use case insensitive search. |
178105c
to
2195f8d
Compare
@SeppoTakalo good point! Now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case should be failing since GPL code is currently in the repo.
@OPpuolitaival I like how quickly this PR came in from when the issue was discovered. However, as this is right now, the test case will either never fail or always fail. This is a quick example of what I mean: cmonr@54e11e2 The second issue is that because this test will fail until the GPL code is removed, it will need to be rebased once a PR is introduced and merged in to remove the offending code. This second issue is more of an FYI. |
@cmonr Actually, GREP return code reflects to findings. From man page:
Git grep --help
So we could use either |
2195f8d
to
7729491
Compare
I tested and return code is same without -q but now changed to use -q option |
Re-opening because this is still an issue. CC: @ARMmbed/mbed-os-maintainers @ChiefBureaucraticOfficer |
Current master should not anymore contain GPL code so this test should pass. |
7729491
to
a4f8c07
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good to know about the -q
flag.
/morph build |
Build : SUCCESSBuild number : 2213 Triggering tests/morph test |
Test : SUCCESSBuild number : 2006 |
Exporter Build : SUCCESSBuild number : 1850 |
Description
Check that there is not GPL licence text in pull request
Pull request type