-
Notifications
You must be signed in to change notification settings - Fork 3k
fix greentea-client, require a character input between K-V pairs #6865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mazimkhan any chance you're more familiar with this part of the greentea-client? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. While we are here can you please fix the indentation of this if
block.
Sorry for the late reply. The change is good. |
Can you update the commit message (contains info from the description - useful info). Plus the first line should be within 50 characters as stated in our guidelines (avoid wrapping, can be seen here on github as well) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM the changes
requesting commit msg update
reset "LastChar" after "tok_close" received fix the bug where greentea-client require a character input between K-V pairs
@0xc0170, Hi Martin, the commit message had been changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'll be ok, running it through the CI tests should catch any issues.
/morph build |
Build : SUCCESSBuild number : 2010 Triggering tests/morph test |
Test : SUCCESSBuild number : 1820 |
Exporter Build : SUCCESSBuild number : 1662 |
Description
Currently, greentea-client require a character input in between 2 K-V pair sync commands.
e.g. between {{__sync;1234}} and {{base_time;0}} in a time drifting test.
This is becasue greentea-client didn't reset the LastChar after it receives "tok_close".
The problem didn't got expose before, becasue in mbedhtrun side, it always insert a line feed "\n" in between any 2 K-V pairs.
in the serial connection, that works fine, cancel out the issue.
However, working with Fast Models, specially in windows enviroment, which use telnet as UART. It which use "\r\n" to flush the buffer, this is causing a problem.
So the fix is to reset "LastChar" after received "tok_close"
Pull request type