Skip to content

Export folder needs to not ignore .mbed files. #6896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2018
Merged

Export folder needs to not ignore .mbed files. #6896

merged 1 commit into from
May 22, 2018

Conversation

Alex-EEE
Copy link
Contributor

Description

Fixing a bug. .mbed is ignored in the high level .gitignore file. But .mbed is actually a needed file inside of tools/export. Even though the file is still in the main repo, since it's ignored now, you can easily lose it or remove it without seeing the change. Adding this .gitignore file here will add .mbed back into the tracked files for only this directory

Pull request type

[X ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Fixing a bug.  .mbed is ignored in the high level .gitignore file.  But .mbed is actually a needed file inside of tools/export.  Even though the file is still in the main repo, since it's ignored now, you can easily lose it or remove it without seeing the change.  Adding this .gitignore file here will add .mbed back into the tracked files for only this directory
@cmonr
Copy link
Contributor

cmonr commented May 15, 2018

Interesting. Wondering why our export tests didn't catch this.
I'm also wondering what that .mbed file is used for since I only saw it referenced once in the entire repo, but I suppose that's a question for @theotherjimmy.

/morph build

@Alex-EEE
Copy link
Contributor Author

Your export test will probably pass b/c the .mbed got into the repository somehow, probably before .mbed was added to the root .gitignore. However you won't ever be able to change that .mbed file b/c going forward git will ignore any changes you make to it. I noticed this issue b/c I'm maintaining a local fork, and it somehow got deleted in one of my merges of the latest mbed-os. Then I tried to export, and the python script most definitely fails if it can't find that .mbed file.

@mbed-ci
Copy link

mbed-ci commented May 15, 2018

Build : SUCCESS

Build number : 2027
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6896/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me.

@cmonr
Copy link
Contributor

cmonr commented May 21, 2018

Relaunching test due to an earlier no-disk-space-left issue.

/morph test

@mbed-ci
Copy link

mbed-ci commented May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants