-
Notifications
You must be signed in to change notification settings - Fork 3k
Export folder needs to not ignore .mbed files. #6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixing a bug. .mbed is ignored in the high level .gitignore file. But .mbed is actually a needed file inside of tools/export. Even though the file is still in the main repo, since it's ignored now, you can easily lose it or remove it without seeing the change. Adding this .gitignore file here will add .mbed back into the tracked files for only this directory
Interesting. Wondering why our export tests didn't catch this. /morph build |
Your export test will probably pass b/c the .mbed got into the repository somehow, probably before .mbed was added to the root .gitignore. However you won't ever be able to change that .mbed file b/c going forward git will ignore any changes you make to it. I noticed this issue b/c I'm maintaining a local fork, and it somehow got deleted in one of my merges of the latest mbed-os. Then I tried to export, and the python script most definitely fails if it can't find that .mbed file. |
Build : SUCCESSBuild number : 2027 Triggering tests/morph test |
Test : FAILUREBuild number : 1833 |
Exporter Build : SUCCESSBuild number : 1676 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good by me.
Relaunching test due to an earlier no-disk-space-left issue. /morph test |
Test : SUCCESSBuild number : 1900 |
Description
Fixing a bug. .mbed is ignored in the high level .gitignore file. But .mbed is actually a needed file inside of tools/export. Even though the file is still in the main repo, since it's ignored now, you can easily lose it or remove it without seeing the change. Adding this .gitignore file here will add .mbed back into the tracked files for only this directory
Pull request type