-
Notifications
You must be signed in to change notification settings - Fork 3k
Lora: Remove obsolete FEATURE_COMMON_PAL flags #6905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kjbracey-arm @hasnainvirk please review |
Hmm, events testing and its "rm assorted bits of tree" strikes again. Add "lorawan" to its delete list? |
Actually no, that'll just make the problem recur in future. You need to narrow down or eliminate its "frameworks" deletion. |
Including mbed_trace.h probably requires the path "mbed-trace". Adding it right now. |
Let's see if deleting features/frameworks/greentea-client instead of whole frameworks is enough. |
mbed-trace no longer requires COMMON_PAL to be enabled.
Adding greentea-client, utest and unity seems to be enough and tests are passing now. @0xc0170 could you start morph tests now? |
/morph build |
Build : SUCCESSBuild number : 2035 Triggering tests/morph test |
Get rid of FEATURE_COMMON_PAL and FEATURE_NANOSTACK
Test : FAILUREBuild number : 1841 |
Exporter Build : FAILUREBuild number : 1683 |
@0xc0170 Could you check these latest test and exporter failures. Probably some CI problem as at least test failure seems to have some disk space problems? |
/morph test |
Test : SUCCESSBuild number : 1860 |
Exporter Build : FAILUREBuild number : 1692 |
/morph export-build |
Exporter Build : ABORTEDBuild number : 1708 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 1716 |
@cmonr Could this go in now ? |
@hasnainvirk It will go in when we do gatekeeping at 4pm :) |
Description
mbed-trace no longer requires
COMMON_PAL
to be enabled.Pull request type