Skip to content

Lora: Remove obsolete FEATURE_COMMON_PAL flags #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2018
Merged

Lora: Remove obsolete FEATURE_COMMON_PAL flags #6905

merged 1 commit into from
May 21, 2018

Conversation

kivaisan
Copy link
Contributor

Description

mbed-trace no longer requires COMMON_PAL to be enabled.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

@kjbracey-arm @hasnainvirk please review

kjbracey
kjbracey previously approved these changes May 15, 2018
@kjbracey
Copy link
Contributor

Hmm, events testing and its "rm assorted bits of tree" strikes again. Add "lorawan" to its delete list?

0xc0170
0xc0170 previously approved these changes May 15, 2018
@kjbracey
Copy link
Contributor

Add "lorawan" to its delete list?

Actually no, that'll just make the problem recur in future. You need to narrow down or eliminate its "frameworks" deletion.

@kivaisan
Copy link
Contributor Author

Including mbed_trace.h probably requires the path "mbed-trace". Adding it right now.

@kivaisan kivaisan dismissed stale reviews from 0xc0170 and kjbracey via 2b8c563 May 15, 2018 12:39
@kivaisan
Copy link
Contributor Author

Hmm, events testing and its "rm assorted bits of tree" strikes again. Add "lorawan" to its delete list?

Let's see if deleting features/frameworks/greentea-client instead of whole frameworks is enough.

mbed-trace no longer requires COMMON_PAL to be enabled.
@kivaisan
Copy link
Contributor Author

Let's see if deleting features/frameworks/greentea-client instead of whole frameworks is enough.

Adding greentea-client, utest and unity seems to be enough and tests are passing now. @0xc0170 could you start morph tests now?

@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

Build : SUCCESS

Build number : 2035
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

0xc0170 referenced this pull request May 16, 2018
Get rid of FEATURE_COMMON_PAL and FEATURE_NANOSTACK
@mbed-ci
Copy link

mbed-ci commented May 16, 2018

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

@kivaisan
Copy link
Contributor Author

@0xc0170 Could you check these latest test and exporter failures. Probably some CI problem as at least test failure seems to have some disk space problems?

@cmonr
Copy link
Contributor

cmonr commented May 17, 2018

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

@kjbracey
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 18, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 19, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 19, 2018

@hasnainvirk
Copy link
Contributor

@cmonr Could this go in now ?

@adbridge
Copy link
Contributor

@hasnainvirk It will go in when we do gatekeeping at 4pm :)

@cmonr cmonr merged commit 16d3077 into ARMmbed:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants