Skip to content

Travis: Quick name-fix for warnings reported by Astyle #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2018
Merged

Travis: Quick name-fix for warnings reported by Astyle #6917

merged 1 commit into from
May 18, 2018

Conversation

geky
Copy link
Contributor

@geky geky commented May 15, 2018

Description

Currently Astyle is reporting files with warnings, not the actual count of warnings. This is a bug, but fixing right now will cause incorrect results (and we're in the middle of preparing a release!). At least for the short-term we can change the name to avoid as much confusion as possible.

cc @0xc0170

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@geky
Travis: Quick name-fix for warnings reported by Astyle
fa54351 
Currently Astyle is reporting files with warnings, not the actual count
of warnings. This is a bug, but fixing right now will cause incorrect results.
At least for the short-term we can change the name to avoid as much confusion
as possible.
0xc0170
0xc0170 approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files 👍 much clearer now, even we got confused today about some +0 warnings reports when there were issues

@cmonr
Copy link
Contributor

cmonr commented May 15, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 15, 2018

Build : SUCCESS

Build number : 2030
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6917/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

Test : FAILURE

Build number : 1836
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6917/1836

@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

Exporter Build : SUCCESS

Build number : 1679
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6917/

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

Test : FAILURE

Build number : 1839
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6917/1839

@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2018

Once the devices are fixed in CI, we will restart tests

@cmonr
Copy link
Contributor

cmonr commented May 17, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

Test : SUCCESS

Build number : 1859
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6917/1859

@cmonr cmonr merged commit bb0c345 into master May 18, 2018
@adbridge
Copy link
Contributor

astyle is targeting 5.9, therefore so should this.

@geky geky deleted the g-astyle-rename-warnings branch May 30, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geky @cmonr @mbed-ci @0xc0170 @adbridge