Skip to content

NVStore - remove Thread.h include #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2018
Merged

NVStore - remove Thread.h include #6940

merged 1 commit into from
May 18, 2018

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented May 17, 2018 •
edited
Loading

Description

Remove include of Thread.h as this include is not actually needed.
Having it will cause issues with the bootloader size, as this will cause
a need to get the full CMSIS/RTOS package etc., which would bloat
the bootloader size.

Minor fix, bootloader compiles with Mbed Cloud supported boards.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

NVStore - remove Thread.h include
16a27a2 
As this include is not actually needed. Having it will cause issues
with the bootloader, as this will cause a need to get the full
CMSIS/RTOS package etc., which would bloat the bootloader size.
@JanneKiiskila
Copy link
Contributor Author

@dannybenor @davidsaada

@davidsaada
Copy link
Contributor

Looks good to me. Include is there by accident probably - no usage of threads in NVStore.

@0xc0170 0xc0170 requested a review from davidsaada May 17, 2018 11:17
davidsaada
davidsaada approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JanneKiiskila
Copy link
Contributor Author

We would want this to the next patch release, please.

@cmonr
Copy link
Contributor

cmonr commented May 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

Build : SUCCESS

Build number : 2051
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6940/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

Test : SUCCESS

Build number : 1861
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6940/1861

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

Exporter Build : FAILURE

Build number : 1694
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6940/

@cmonr
Copy link
Contributor

cmonr commented May 18, 2018

Launching this again.
Amidst the sea of "license is expiring" errors, this one error stuck out:

A1023E: File "/tmp/fileFp0UTL" could not be opened: No such file or directory
1 Error, 1 Warning

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 18, 2018

Exporter Build : SUCCESS

Build number : 1701
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6940/

@0xc0170 0xc0170 merged commit 79640c6 into ARMmbed:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@davidsaada davidsaada davidsaada approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JanneKiiskila @davidsaada @cmonr @mbed-ci @0xc0170