Skip to content

EFM32PG12_STK3402 - Correct wrong Expansion-Header pin namings #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2018
Merged

EFM32PG12_STK3402 - Correct wrong Expansion-Header pin namings #6947

merged 1 commit into from
May 29, 2018

Conversation

DBS06
Copy link
Contributor

@DBS06 DBS06 commented May 18, 2018

Description

Referencing to "UG257: EFM32 Pearl Gecko PG12 Starter Kit User's Guide - Chapter 4" (https://www.silabs.com/documents/public/user-guides/ug257-stk3402-usersguide.pdf) the pin namings for the Expansion-Header are incorrect.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@steinerphilipp
EFM32PG12_STK3402 - Correct wrong Expansion header Pin naming
6920745 
Referencing to "UG257: EFM32 Pearl Gecko PG12 Starter Kit User's Guide - Chapter 4" (https://www.silabs.com/documents/public/user-guides/ug257-stk3402-usersguide.pdf) it should be like in this commit.
@DBS06 DBS06 changed the title EFM32PG12_STK3402 - Correct wrong Expansion header Pin naming EFM32PG12_STK3402 - Correct wrong Expansion header Pin namings May 18, 2018
@DBS06 DBS06 changed the title EFM32PG12_STK3402 - Correct wrong Expansion header Pin namings EFM32PG12_STK3402 - Correct wrong Expansion header pin namings May 18, 2018
@DBS06 DBS06 changed the title EFM32PG12_STK3402 - Correct wrong Expansion header pin namings EFM32PG12_STK3402 - Correct wrong Expansion-Header pin namings May 18, 2018
@0xc0170 0xc0170 requested a review from a team May 18, 2018 09:00
stevew817
stevew817 approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@stevew817 stevew817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry that this happened - glad someone caught it!

@stevew817 stevew817 mentioned this pull request May 18, 2018
Closed
@stevew817
Copy link
Contributor

@0xc0170 Can you start CI on this?

@stevew817
Copy link
Contributor

@ARMmbed/mbed-os-maintainers Anyone?

@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2018

Starting CI soon, sorry for the delay. We were finishing release candidate for upcoming minor.

@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2179
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6947/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Test : SUCCESS

Build number : 1967
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6947/1967

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Exporter Build : SUCCESS

Build number : 1804
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6947/

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

/morph mbed2-build

@cmonr cmonr merged commit fe43377 into ARMmbed:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@stevew817 stevew817 stevew817 approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.6 release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DBS06 @stevew817 @0xc0170 @mbed-ci @cmonr @steinerphilipp