Skip to content

STM32 ETH : remove TX RX locking interrupt perforation #6948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

See #6610 for detailed analysis

@pauluap
I have updated F7 file, as I think you miss some LOCK and UNLOCK ?

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested review from kjbracey and a team May 18, 2018 09:00
@pauluap
Copy link

pauluap commented May 18, 2018

@jeromecoutant, my intention was only to resolve the perforation issue. I didn't touch the other HAL locks because I didn't really understand their purpose. HAL locking seems to be a fundamental part of the STMCube design.

It seems that you have determined that HAL locking isn't necessary for the MAC HAL module. That's cool, good information to know.

I have no information that suggests that this will (or will not for that matter) be an issue. For mbed at least, I don't project any problems since the mac configuration is done from a single thread, the phy register read, rx and tx seem to be just fine running in different threads.

@pauluap
Copy link

pauluap commented May 18, 2018

@jeromecoutant Oops, I stand corrected. Yes, you're right, I missed the updating the non-_IT versions in F7 because my code wasn't using those. I'm glad that you caught the one at the end of GetReceivedFrame_IT, in removing one perforation, I introduced another!

My apologizes

@jeromecoutant
Copy link
Collaborator Author

@bcostm @kjbracey-arm

Any comment ? Thx

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2018

/morph build

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 8, 2018

Build : SUCCESS

Build number : 2286
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6948/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Jun 8, 2018

Pausing CI until 5.9 RC3 completes CI. Will restart jobs when able.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2018

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants