-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32 ETH : remove TX RX locking interrupt perforation #6948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant, my intention was only to resolve the perforation issue. I didn't touch the other HAL locks because I didn't really understand their purpose. HAL locking seems to be a fundamental part of the STMCube design. It seems that you have determined that HAL locking isn't necessary for the MAC HAL module. That's cool, good information to know. I have no information that suggests that this will (or will not for that matter) be an issue. For mbed at least, I don't project any problems since the mac configuration is done from a single thread, the phy register read, rx and tx seem to be just fine running in different threads. |
@jeromecoutant Oops, I stand corrected. Yes, you're right, I missed the updating the non-_IT versions in F7 because my code wasn't using those. I'm glad that you caught the one at the end of GetReceivedFrame_IT, in removing one perforation, I introduced another! My apologizes |
@bcostm @kjbracey-arm Any comment ? Thx |
/morph build |
1 similar comment
/morph build |
Build : SUCCESSBuild number : 2286 Triggering tests/morph test |
Pausing CI until 5.9 RC3 completes CI. Will restart jobs when able. |
/morph test |
Test : SUCCESSBuild number : 2065 |
Exporter Build : SUCCESSBuild number : 1909 |
Description
See #6610 for detailed analysis
@pauluap
I have updated F7 file, as I think you miss some LOCK and UNLOCK ?
Pull request type