LoRaWAN: Message flags correction

[hasnainvirk]

Description

Uplink multicast is not allowed. Proprietary messages cannot be
of type unconfirmed and unconfirmed.

Some error flags are introduced which check in the UP direction
if the user have used the flags wrongly.

Target version

Mbed OS-5.9-rc1

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

[hasnainvirk]

@kjbracey-arm @AnttiKauppila @kivaisan @0xc0170 Please review.

[hasnainvirk]

@0xc0170 Could you please reset the CI build for this PR ?

[kjbracey]

What if neither are set (and it's a normal message)? Seems like this might be simpler if confirmed/unconfirmed was a single flag.

This is all very wordy to do a very simple test. I'd be vaguely inclined to just list out the valid values thus:

switch (flags) {   /* or (flags & MSG_FLAG_MASK) ? */
     case UNCONFIRMED:
     case CONFIRMED:
     case PROPRIETARY:
          break;
  
     default:
          tr_error("Invalid send flags");
          return LORAWAN_STATUS_PARAMETER_INVALID;
 }

[hasnainvirk]

case 1 handles if nothing is set. Multicast flag cannot be set for uplink. And all the flags are mutually exclusive, so they can't be used in pairs for uplink.

[hasnainvirk]

@kjbracey-arm Please review again.

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2114
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6960/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Test : FAILURE

Build number : 1915
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6960/1915

[cmonr]

Looked like there was a problem device in CI. Restarting test.

/morph test

[cmonr]

Shuffling around some jobs.

/morph export-build

[cmonr]

/morph test

[mbed-ci]

Test : SUCCESS

Build number : 1923
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6960/1923

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1755
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6960/