Skip to content

Cellular: Unit tests fixes #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2018
Merged

Cellular: Unit tests fixes #6965

merged 3 commits into from
May 29, 2018

Conversation

mirelachirica
Copy link
Contributor

Description

Fixes for following issues:

  • missing rtos::Thread::wait_until stub after such call was introduced to ATHandler
  • missing poll_stub setting for reading routines after poll(...) replaced the filehandle read loop in ATHandler
  • wrong location for unit test's mbed_retarget.h and missing sys/types.h include for ssize_t type

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mirelachirica
Copy link
Contributor Author

@jarvte and @AriParkkila please review this

@0xc0170 0xc0170 requested a review from a team May 22, 2018 08:07
jarvte
jarvte suggested changes May 22, 2018
View reviewed changes
features/cellular/UNITTESTS/target_h/cmsis_os.h
@@ -0,0 +1,13 @@
#ifndef CMSIS_OS_H_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyrights.

features/cellular/UNITTESTS/target_h/mbed_rtx_conf.h
@@ -0,0 +1 @@
#define OS_STACK_SIZE 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyrights.

features/cellular/UNITTESTS/target_h/rtos/Mutex.h
@@ -0,0 +1 @@
typedef void* Mutex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyrights.

features/cellular/UNITTESTS/target_h/rtos/Semaphore.h
@@ -0,0 +1 @@
typedef void* Semaphore;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyrights.

jarvte
jarvte previously approved these changes May 22, 2018
View reviewed changes
AnttiKauppila
AnttiKauppila previously approved these changes May 22, 2018
View reviewed changes
@mirelachirica
Copy link
Contributor Author

I'm going to rebase.

@mirelachirica mirelachirica dismissed stale reviews from AnttiKauppila and jarvte via 853c4c6 May 23, 2018 09:39
@mirelachirica
Copy link
Contributor Author

Who's review is needed for this to proceed?

@AnttiKauppila
Copy link

@jarvte is on sick leave, but his comment has been addressed. This is ready to be merged

@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2181
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6965/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Test : FAILURE

Build number : 1969
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6965/1969

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Exporter Build : SUCCESS

Build number : 1806
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6965/

@AnttiKauppila
Copy link

@0xc0170 Can you retrigger failed test. For some reason NRF51_DK timed out.

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Test : SUCCESS

Build number : 1971
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6965/1971

@cmonr cmonr merged commit 206cab9 into ARMmbed:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

@jarvte jarvte jarvte left review comments

Assignees
No one assigned
Labels
release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mirelachirica @AnttiKauppila @0xc0170 @mbed-ci @AriParkkila @jarvte @cmonr