Skip to content

Fixes to EFM32 port #6970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2018
Merged

Fixes to EFM32 port #6970

merged 2 commits into from
May 29, 2018

Conversation

stevew817
Copy link
Contributor

Description

  • Minimum write size was incorrectly being reported as a whole page, instead of the actual write unit of 32-bit
  • Flash API was running as ramfunc by default, whereas mbed doesn't have a need for that
  • Moved pin PF7 for SPI from SPI_1 to SPI_2 to accomodate updated TB_SENSE_12 pinout
  • Updated TB_SENSE_12 EXP pin assignments to match the production revision of the board instead of pre-production

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

0xc0170
0xc0170 requested changes May 22, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good but would be better if they come as separate commits (flash fixes, pins fix). Please split those 2

stevew817 added 2 commits May 22, 2018 22:54
@stevew817
Update pinout of TB_SENSE_12 to production revision
30db7fd 
* Updated pinout of EXP header from pre-production to production
* Move assignment of PF7 to SPI_2 to be compatible with the new SPI flash routing
@stevew817
Fix to flash API on EFM32
c2bc20e 
* Since mbed does not overwrite itself, make the flashing routines run out of flash by default
* Report a writeable size of 4 bytes (previously erroneously reported a full eraseable page as the minimum write size)
@stevew817 stevew817 force-pushed the efm32_flash_bugfix branch from b6eed0a to c2bc20e Compare May 22, 2018 20:55
@stevew817
Copy link
Contributor Author

@0xc0170 Commits are now split

@stevew817
Copy link
Contributor Author

@0xc0170 Can you move this along, please? I split up the commits as you requested.

@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2175
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6970/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Test : SUCCESS

Build number : 1963
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6970/1963

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Exporter Build : ABORTED

Build number : 1800
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6970/

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Exporter Build : SUCCESS

Build number : 1808
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6970/

@cmonr cmonr merged commit 1a0c2d0 into ARMmbed:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.6 release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevew817 @0xc0170 @mbed-ci @cmonr