STM32 ADC update #6987

jeromecoutant · 2018-05-23T11:47:32Z

Description

This PR extends #6399 (increase sampling time for ADC internal channels)
and #6412 (Only 1 internal channel could be configured which was wrong)
for all STM32 families

Tests from #6397 and #6398 have been verified for all targets

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

bcostm · 2018-05-23T13:03:36Z

targets/TARGET_STM/TARGET_STM32F0/analogin_device.c

-    // ADC calibration is done only once
-    if (!adc_calibrated) {
-        adc_calibrated = true;
+    if (!LL_ADC_REG_ReadConversionData6(obj->handle.Instance)) {


I don't understand how this macro can determine if the calibration has been done or not ?

Check RM:
ADC data register (ADC_DR)
Just after a calibration is complete, DATA[6:0] contains the calibration factor

bcostm · 2018-05-23T13:21:49Z

targets/TARGET_STM/TARGET_STM32F3/device/stm32f3xx_hal_adc_ex.c

@@ -5660,12 +5660,6 @@ HAL_StatusTypeDef HAL_ADC_ConfigChannel(ADC_HandleTypeDef* hadc, ADC_ChannelConf
      /* Set handle of the other ADC sharing the same common register         */
      ADC_COMMON_ADC_OTHER(hadc, &tmphadcSharingSameCommonRegister);



why is it removed ? Is it a patch that we have added previously ?

yes, same kind of patch as #6412

bcostm · 2018-05-23T13:23:41Z

targets/TARGET_STM/TARGET_STM32F4/device/stm32f4xx_ll_adc.h

+#define TEMPSENSOR_CAL1_TEMP               (( int32_t)   30)           /* Internal temperature sensor, temperature at which temperature sensor has been calibrated in production for data into TEMPSENSOR_CAL1_ADDR (tolerance: +-5 DegC) (unit: DegC). */
+#define TEMPSENSOR_CAL2_TEMP               (( int32_t)  110)           /* Internal temperature sensor, temperature at which temperature sensor has been calibrated in production for data into TEMPSENSOR_CAL2_ADDR (tolerance: +-5 DegC) (unit: DegC). */
+#define TEMPSENSOR_CAL_VREFANALOG          ( 3300U)                    /* Analog voltage reference (Vref+) voltage with which temperature sensor has been calibrated in production (+-10 mV) (unit: mV). */
+


Why did you add this ?

To align with other STM32 families,
and be able to execute application like the one in #6398

cmonr · 2018-05-31T16:11:12Z

/morph build

mbed-ci · 2018-05-31T17:29:38Z

Build : FAILURE

Build number : 2202
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6987/

cmonr · 2018-05-31T17:34:18Z

Restarting CI. Multiple defined symbols seems like an old CI issue that hadn't shown up in a while.

[DEBUG] Errors: "/tmp/a7H4vd", line 124 (column 3): Warning: L6312W: Empty Execution region description for region RW_IRAM1
[DEBUG] Errors: Error: L6200E: Symbol __asm___10_fsl_rnga_c_3e53f3f3____REV16 multiply defined (by BUILD/K64F/ARM/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/fsl_rnga.o and BUILD/K64F/ARM/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/fsl_pit.o).
[DEBUG] Errors: Error: L6200E: Symbol __asm___10_fsl_rnga_c_3e53f3f3____REVSH multiply defined (by BUILD/K64F/ARM/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/fsl_rnga.o and BUILD/K64F/ARM/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/fsl_pit.o).
[DEBUG] Errors: Error: L6200E: Symbol __asm___10_fsl_rnga_c_3e53f3f3____RRX multiply defined (by BUILD/K64F/ARM/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/fsl_rnga.o and BUILD/K64F/ARM/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/fsl_pit.o).

/morph build

mbed-ci · 2018-06-01T00:14:04Z

Build : SUCCESS

Build number : 2210
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6987/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-01T12:04:10Z

Test : SUCCESS

Build number : 2003
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6987/2003

cmonr · 2018-06-01T12:08:38Z

FYI @studavekar

mbed-ci · 2018-06-01T15:28:26Z

Exporter Build : ABORTED

Build number : 1837
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6987/

cmonr · 2018-06-01T15:30:04Z

Export node got stuck.
/morph export-build

mbed-ci · 2018-06-02T05:22:37Z

Exporter Build : SUCCESS

Build number : 1845
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6987/

cmonr · 2018-06-02T07:12:47Z

/morph uvisor-test

jeromecoutant added 9 commits May 22, 2018 11:32

STM32F4 ADC internal channels update

cb579cb

STM32F0 ADC internal channels update

d7932c2

STM32F1 ADC internal channels update

743a812

STM32F2 ADC internal channels update

5f21c3f

STM32F3 ADC internal channels update

e438bd6

STM32F7 ADC internal channels update

06bca28

STM32L0 ADC internal channels update

4d3a544

STM32L1 ADC internal channels update

881a8e3

STM32L4 ADC internal channels update

7fd4203

0xc0170 added the needs: review label May 23, 2018

0xc0170 requested a review from a team May 23, 2018 12:01

bcostm reviewed May 23, 2018

View reviewed changes

bcostm approved these changes May 23, 2018

View reviewed changes

cmonr approved these changes May 31, 2018

View reviewed changes

cmonr added release-version: 5.8.6 release-version: 5.9.1 needs: CI and removed needs: review labels May 31, 2018

cmonr merged commit 07fb7c1 into ARMmbed:master Jun 3, 2018

cmonr removed the needs: CI label Jun 3, 2018

jeromecoutant deleted the PR_ADC branch June 4, 2018 07:22

		@@ -5660,12 +5660,6 @@ HAL_StatusTypeDef HAL_ADC_ConfigChannel(ADC_HandleTypeDef* hadc, ADC_ChannelConf
		/* Set handle of the other ADC sharing the same common register */
		ADC_COMMON_ADC_OTHER(hadc, &tmphadcSharingSameCommonRegister);

STM32 ADC update #6987

STM32 ADC update #6987

Uh oh!

Conversation

jeromecoutant commented May 23, 2018

Description

Pull request type

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented May 31, 2018

Uh oh!

mbed-ci commented May 31, 2018

Uh oh!

cmonr commented May 31, 2018

Uh oh!

mbed-ci commented Jun 1, 2018

Triggering tests

Uh oh!

mbed-ci commented Jun 1, 2018

Uh oh!

cmonr commented Jun 1, 2018

Uh oh!

mbed-ci commented Jun 1, 2018

Uh oh!

cmonr commented Jun 1, 2018

Uh oh!

mbed-ci commented Jun 2, 2018

Uh oh!

cmonr commented Jun 2, 2018

Uh oh!

Uh oh!