Skip to content

EFM32: make mbed_rtx.h depend of families instead of targets #6991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2018

Conversation

amq
Copy link
Contributor

@amq amq commented May 23, 2018

Description

Currently, custom targets based on these families would require a fork of mbed-os, otherwise the build would fail on an undefined INITIAL_SP:

  • EFM32GG
  • EFM32HG
  • EFM32LG
  • EFM32PG
  • EFM32WG

This is due to specific targets like EFM32GG_STK3700 being used in mbed_rtx.h, instead of families such as EFM32GG.

The newest families EFR32MG12 and EFM32PG12 do not have this issue. This PR aligns mbed_rtx.h with the approach of these new families.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team May 23, 2018 17:57
Copy link
Contributor

@stevew817 stevew817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented May 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 26, 2018

Build : SUCCESS

Build number : 2160
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6991/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 26, 2018

@mbed-ci
Copy link

mbed-ci commented May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants