Add check for _interface #7014
Merged
Add check for _interface #7014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kjbracey-arm Kevin, could you please review this |
kjbracey
reviewed
May 25, 2018
features/netsocket/EMACInterface.cpp
Outdated
| } | ||
|
|
||
| const char *EMACInterface::get_mac_address() | ||
| { | ||
| if (_interface->get_mac_address(_mac_address, sizeof(_mac_address))) { | ||
| return _mac_address; | ||
| if (_interface) { |
There was a problem hiding this comment.
Tould you squidge these down to just if (_interface && _interface->xxx)?
SeppoTakalo
approved these changes
May 25, 2018
mikaleppanen
approved these changes
May 25, 2018
|
/morph build |
Build : SUCCESSBuild number : 2176 Triggering tests/morph test |
Test : SUCCESSBuild number : 1964 |
Exporter Build : SUCCESSBuild number : 1801 |
0xc0170
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add check for _interface -variable
Pull request type