-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix lwIP PPP glue #7030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lwIP PPP glue #7030
Conversation
EMAC changes broke PPP glue - fix it up. In particular, PPP steals the netif->state pointer, so we can't use it as a back pointer to our LWIP::Interface.
/morph build |
Build : SUCCESSBuild number : 2173 Triggering tests/morph test |
Test : SUCCESSBuild number : 1961 |
Exporter Build : FAILUREBuild number : 1797 |
Exporter failed on CPU stats examples - as if the patches done to make #7009 pass hadn't been applied? |
Tip of this branch precedes #7009. Is the exporter testing the branch tip rather than the merge result? That would explain it - it's seeing |
Ah, 7009 was not merged when exporter test was launched. Will pass next time. /morph export-build |
Exporter Build : SUCCESSBuild number : 1798 |
Description
EMAC changes broke PPP glue - fix it up. In particular, PPP steals
the netif->state pointer, so we can't use it as a back pointer to
our LWIP::Interface.
Pull request type