Skip to content

Fix lwIP PPP glue #7030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2018
Merged

Fix lwIP PPP glue #7030

merged 1 commit into from
May 28, 2018

Conversation

kjbracey
Copy link
Contributor

Description

EMAC changes broke PPP glue - fix it up. In particular, PPP steals
the netif->state pointer, so we can't use it as a back pointer to
our LWIP::Interface.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

EMAC changes broke PPP glue - fix it up. In particular, PPP steals
the netif->state pointer, so we can't use it as a back pointer to
our LWIP::Interface.
@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2173
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7030/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

@kjbracey
Copy link
Contributor Author

Exporter failed on CPU stats examples - as if the patches done to make #7009 pass hadn't been applied?

@kjbracey
Copy link
Contributor Author

Tip of this branch precedes #7009. Is the exporter testing the branch tip rather than the merge result?

That would explain it - it's seeing DEVICE_LOWPOWERTIMER on the tip here when the test expects DEVICE_LPTICKER.

@kjbracey
Copy link
Contributor Author

Ah, 7009 was not merged when exporter test was launched. Will pass next time.

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 28, 2018

@0xc0170 0xc0170 merged commit 5d8570b into ARMmbed:master May 28, 2018
@kjbracey kjbracey deleted the emac_ppp_fix branch May 28, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants