-
Notifications
You must be signed in to change notification settings - Fork 3k
[TEST] Corrected instance of Arm branding #7049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
👍 |
Build : SUCCESSBuild number : 2191 Triggering tests/morph test |
Test : FAILUREBuild number : 1980 |
I've only looked at a couple of logs, but it looked like everything failed the tests-mbed_platform-stats_sys test? |
Exporter Build : SUCCESSBuild number : 1817 |
@cmonr @0xc0170 By writing our company/processor/architecture name, it should be Arm (not arm). https://www.arm.com/company/policies/trademarks/guidelines-trademarks |
@toyowata +1, this is just to test the branch, not real change. I corrected the title |
@deepikabhavnani Line 36 fails in sys stats, I am investigating why. To me it seems like that version depends on MBED_VERSION which is true for only releases, master does not have a version.
As master did not fail, release branch changes the test to cause it to fail |
Restarted both failing CI. I can confirm the above. This is the test result after I define MBED_VERSION in the mbed_stats.c file (otherwise it fails). The cause is - test gets mbed.h in, so version is defined, but stats implementation does not:
mbed_stats code file (it's C file so can't just include mbed.h and should not) do not see |
@ARMmbed/mbed-os-maintainers This PR (#7059 (comment)) is the fix for this test issue. |
I believe we can close this one . We have test results, known issue that is being fixed .Rc2 will be tested , so will get new test results. |
Description
Tiny docs change to generate test results against branch, similar to patch releases.
Pull request type