Skip to content

[TEST] Corrected instance of Arm branding #7049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented May 29, 2018

Description

Tiny docs change to generate test results against branch, similar to patch releases.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested a review from a team May 29, 2018 19:56
@cmonr
Copy link
Contributor Author

cmonr commented May 29, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2018

👍

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

Build : SUCCESS

Build number : 2191
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7049/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 29, 2018

@cmonr
Copy link
Contributor Author

cmonr commented May 29, 2018

I've only looked at a couple of logs, but it looked like everything failed the tests-mbed_platform-stats_sys test?

@mbed-ci
Copy link

mbed-ci commented May 30, 2018

@toyowata
Copy link
Contributor

@cmonr @0xc0170 By writing our company/processor/architecture name, it should be Arm (not arm).

https://www.arm.com/company/policies/trademarks/guidelines-trademarks

@0xc0170 0xc0170 changed the title Corrected instance of ARM branding Corrected instance of Arm branding (test) May 30, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2018

@toyowata +1, this is just to test the branch, not real change. I corrected the title

@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2018

@deepikabhavnani Line 36 fails in sys stats, I am investigating why. To me it seems like that version depends on MBED_VERSION which is true for only releases, master does not have a version.

#if defined(MBED_VERSION)
    TEST_ASSERT_NOT_EQUAL(0, stats.os_version);
#endif

mbed_stats.c file - how this one gets MBED_VERSION - to me it does not get it. This is defined in mbed.h and it does not include it (this is tricky, as that implementation file should not include mbed.h but if we have version defined only there, what else?)

As master did not fail, release branch changes the test to cause it to fail

@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2018

Restarted both failing CI.

I can confirm the above. This is the test result after I define MBED_VERSION in the mbed_stats.c file (otherwise it fails). The cause is - test gets mbed.h in, so version is defined, but stats implementation does not:

mbedgt: test case report:
+-----------------------+---------------+-------------------------------+---------------+--------+--------+--------+--------------------+
| target                | platform_name | test suite                    | test case     | passed | failed | result | elapsed_time (sec) |
+-----------------------+---------------+-------------------------------+---------------+--------+--------+--------+--------------------+
| NUCLEO_F401RE-GCC_ARM | NUCLEO_F401RE | tests-mbed_platform-stats_sys | Test Sys Info | 1      | 0      | OK     | 0.04               |
+-----------------------+---------------+-------------------------------+---------------+--------+--------+--------+--------------------+

mbed_stats code file (it's C file so can't just include mbed.h and should not) do not see MBED_VERSION macro therefore it fails for the release branch.

@cmonr cmonr changed the title Corrected instance of Arm branding (test) [TEST] Corrected instance of Arm branding May 30, 2018
@cmonr
Copy link
Contributor Author

cmonr commented Jun 1, 2018

@ARMmbed/mbed-os-maintainers This PR (#7059 (comment)) is the fix for this test issue.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2018

I believe we can close this one . We have test results, known issue that is being fixed .Rc2 will be tested , so will get new test results.

@0xc0170 0xc0170 closed this Jun 4, 2018
@cmonr cmonr deleted the gen-5.9-test-results branch September 26, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants