Add ISM43362 driver support for STM32 wifi DISCO boards #7067

jeromecoutant · 2018-05-31T08:20:28Z

Description

I would like to make wifi tests enable for STM32.

ISM 43362 Wifi drivers : https://github.com/ARMmbed/wifi-ism43362

This WiFi Inventek module is currenlty available with 2 ST DISCO boards:

DISCO_L475VG_IOT01A : https://os.mbed.com/platforms/ST-Discovery-L475E-IOT01A/
DISCO_F413ZH : https://os.mbed.com/platforms/ST-Discovery-F413H/

3 tests supported:

tests-netsocket-tcp
tests-netsocket-udp
tests-network-wifi

Test status

| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-tcp | TCPSOCKET_ECHOTEST                 | 1      | 0      | OK     | 5.4                |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-tcp | TCPSOCKET_ECHOTEST_NONBLOCK        | 1      | 0      | OK     | 7.95               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-tcp | TCPSOCKET_OPEN_CLOSE_REPEAT        | 1      | 0      | OK     | 0.14               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-tcp | TCPSOCKET_OPEN_LIMIT               | 1      | 0      | OK     | 0.59               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-tcp | TCPSOCKET_THREAD_PER_SOCKET_SAFETY | 1      | 0      | OK     | 5.26               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-udp | UDPSOCKET_ECHOTEST_NONBLOCK        | 1      | 0      | OK     | 11.26              |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-udp | UDPSOCKET_OPEN_CLOSE_REPEAT        | 1      | 0      | OK     | 0.14               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-udp | UDPSOCKET_OPEN_LIMIT               | 1      | 0      | OK     | 0.59               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-netsocket-udp | UDPSOCKET_SENDTO_TIMEOUT           | 1      | 0      | OK     | 0.2                |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT                       | 1      | 0      | OK     | 1.57               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-DISCONNECT-REPEAT     | 1      | 0      | OK     | 15.09              |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-NOCREDENTIALS         | 1      | 0      | OK     | 0.06               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-PARAMS-CHANNEL        | 1      | 0      | OK     | 0.09               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-PARAMS-CHANNEL-FAIL   | 1      | 0      | OK     | 0.11               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-PARAMS-NULL           | 1      | 0      | OK     | 0.04               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-PARAMS-VALID-SECURE   | 1      | 0      | OK     | 3.89               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-PARAMS-VALID-UNSECURE | 1      | 0      | OK     | 2.96               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-SECURE                | 1      | 0      | OK     | 3.75               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONNECT-SECURE-FAIL           | 1      | 0      | OK     | 21.46              |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-CONSTRUCTOR                   | 1      | 0      | OK     | 0.55               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-GET-RSSI                      | 1      | 0      | OK     | 2.2                |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-SCAN                          | 1      | 0      | OK     | 2.79               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-SCAN-NULL                     | 1      | 0      | OK     | 2.78               |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-SET-CHANNEL                   | 1      | 0      | OK     | 0.1                |
| DISCO_F413ZH-ARM | DISCO_F413ZH  | tests-network-wifi  | WIFI-SET-CREDENTIAL                | 1      | 0      | OK     | 0.07               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-tcp | TCPSOCKET_ECHOTEST                 | 1      | 0      | OK     | 5.36               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-tcp | TCPSOCKET_ECHOTEST_NONBLOCK        | 1      | 0      | OK     | 7.91               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-tcp | TCPSOCKET_OPEN_CLOSE_REPEAT        | 1      | 0      | OK     | 0.14               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-tcp | TCPSOCKET_OPEN_LIMIT               | 1      | 0      | OK     | 0.59               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-tcp | TCPSOCKET_THREAD_PER_SOCKET_SAFETY | 1      | 0      | OK     | 5.28               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-udp | UDPSOCKET_ECHOTEST_NONBLOCK        | 1      | 0      | OK     | 11.34              |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-udp | UDPSOCKET_OPEN_CLOSE_REPEAT        | 1      | 0      | OK     | 0.14               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-udp | UDPSOCKET_OPEN_LIMIT               | 1      | 0      | OK     | 0.59               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-netsocket-udp | UDPSOCKET_SENDTO_TIMEOUT           | 1      | 0      | OK     | 0.23               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT                       | 1      | 0      | OK     | 1.55               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-DISCONNECT-REPEAT     | 1      | 0      | OK     | 15.01              |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-NOCREDENTIALS         | 1      | 0      | OK     | 0.07               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-PARAMS-CHANNEL        | 1      | 0      | OK     | 0.11               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-PARAMS-CHANNEL-FAIL   | 1      | 0      | OK     | 0.11               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-PARAMS-NULL           | 1      | 0      | OK     | 0.06               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-PARAMS-VALID-SECURE   | 1      | 0      | OK     | 3.92               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-PARAMS-VALID-UNSECURE | 1      | 0      | OK     | 2.95               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-SECURE                | 1      | 0      | OK     | 6.07               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONNECT-SECURE-FAIL           | 1      | 0      | OK     | 21.51              |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-CONSTRUCTOR                   | 1      | 0      | OK     | 0.56               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-GET-RSSI                      | 1      | 0      | OK     | 2.23               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-SCAN                          | 1      | 0      | OK     | 2.8                |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-SCAN-NULL                     | 1      | 0      | OK     | 2.78               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-SET-CHANNEL                   | 1      | 0      | OK     | 0.1                |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-network-wifi  | WIFI-SET-CREDENTIAL                | 1      | 0      | OK     | 0.05               |

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

AnttiKauppila · 2018-05-31T13:26:18Z

@SeppoTakalo Please verify this with your team

SeppoTakalo · 2018-05-31T13:33:11Z

I would like to see ARMmbed/wifi-ism43362#15 fixed before.

SeppoTakalo · 2018-06-04T09:09:48Z

@adbridge @0xc0170 What is your opinion, do we provide test configuration for something that Mbed OS does not support? This needs external repository.

I feel like this is a bit wrong place for this configuration file. Probably needs to live with the driver, as it is an external repo.

Maybe we need to push the ESP configuration out as well, and leave only ones that live inside Mbed OS.

2 DISCO boards: - DISCO_F413ZH - DISCO_L475VG_IOT01A 3 tests supported: - tests-netsocket-tcp - tests-netsocket-udp - tests-network-wifi

jeromecoutant · 2018-06-04T12:18:54Z

Hi

@cmonr you can remove the "preceding PR" label as ARMmbed/wifi-ism43362#15 is closed and ARMmbed/wifi-ism43362#16 is merged

@SeppoTakalo you're right, wifi driver is an external repo, I have then updated the default_test_configuration from ISM43362_WIFI to NONE

Regards,

0xc0170 · 2018-06-05T14:25:02Z

@adbridge @0xc0170 What is your opinion, do we provide test configuration for something that Mbed OS does not support? This needs external repository.
I feel like this is a bit wrong place for this configuration file. Probably needs to live with the driver, as it is an external repo.
Maybe we need to push the ESP configuration out as well, and leave only ones that live inside Mbed OS.

2 boards have this module on board, the driver is outside of Mbed OS. Thus the driver should have test config for those targets.
@SenRamakri @bulislaw Please review this and advice

jeromecoutant · 2018-06-06T08:33:35Z

Hi

I have updated the json file according to the last patch : ARMmbed/wifi-ism43362#18

I think you can start morph build

cmonr · 2018-06-06T16:46:09Z

/morph build

mbed-ci · 2018-06-06T23:25:49Z

Build : SUCCESS

Build number : 2256
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7067/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-07T07:40:52Z

Test : SUCCESS

Build number : 2045
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7067/2045

mbed-ci · 2018-06-07T12:37:45Z

Exporter Build : SUCCESS

Build number : 1881
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7067/

jeromecoutant · 2018-06-08T12:34:28Z

Hi

For information : https://os.mbed.com/teams/ST/wiki/How-to-make-wifi-tests

adbridge added the needs: review label May 31, 2018

adbridge requested review from a team and removed request for a team May 31, 2018 11:40

cmonr added the needs: preceding PR label May 31, 2018

Add ISM43362 driver support for STM32 wifi DISCO boards

1884070

2 DISCO boards: - DISCO_F413ZH - DISCO_L475VG_IOT01A 3 tests supported: - tests-netsocket-tcp - tests-netsocket-udp - tests-network-wifi

jeromecoutant force-pushed the PR_ISM43362 branch from 3f6ddec to 1884070 Compare June 4, 2018 12:15

cmonr removed the needs: preceding PR label Jun 4, 2018

ISM pin configuration is now in ISM driver json file

0c6844d

SeppoTakalo previously approved these changes Jun 5, 2018

View reviewed changes

jeromecoutant dismissed SeppoTakalo’s stale review via 0c6844d June 6, 2018 08:30

0xc0170 approved these changes Jun 6, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Jun 6, 2018

cmonr added ready for merge release-version: 5.9.1 and removed needs: CI labels Jun 7, 2018

cmonr merged commit d216602 into ARMmbed:master Jun 7, 2018

kegilbert removed the ready for merge label Jun 7, 2018

jeromecoutant deleted the PR_ISM43362 branch June 7, 2018 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ISM43362 driver support for STM32 wifi DISCO boards #7067

Add ISM43362 driver support for STM32 wifi DISCO boards #7067

Uh oh!

jeromecoutant commented May 31, 2018 •

edited by cmonr

Loading

Uh oh!

AnttiKauppila commented May 31, 2018

Uh oh!

SeppoTakalo commented May 31, 2018

Uh oh!

SeppoTakalo commented Jun 4, 2018

Uh oh!

jeromecoutant commented Jun 4, 2018

Uh oh!

0xc0170 commented Jun 5, 2018

Uh oh!

jeromecoutant commented Jun 6, 2018

Uh oh!

cmonr commented Jun 6, 2018

Uh oh!

mbed-ci commented Jun 6, 2018

Uh oh!

mbed-ci commented Jun 7, 2018

Uh oh!

mbed-ci commented Jun 7, 2018

Uh oh!

jeromecoutant commented Jun 8, 2018

Uh oh!

Uh oh!

Add ISM43362 driver support for STM32 wifi DISCO boards #7067

Add ISM43362 driver support for STM32 wifi DISCO boards #7067

Uh oh!

Conversation

jeromecoutant commented May 31, 2018 • edited by cmonr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test status

Pull request type

Uh oh!

AnttiKauppila commented May 31, 2018

Uh oh!

SeppoTakalo commented May 31, 2018

Uh oh!

SeppoTakalo commented Jun 4, 2018

Uh oh!

jeromecoutant commented Jun 4, 2018

Uh oh!

0xc0170 commented Jun 5, 2018

Uh oh!

jeromecoutant commented Jun 6, 2018

Uh oh!

cmonr commented Jun 6, 2018

Uh oh!

mbed-ci commented Jun 6, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Jun 7, 2018

Test : SUCCESS

Uh oh!

mbed-ci commented Jun 7, 2018

Exporter Build : SUCCESS

Uh oh!

jeromecoutant commented Jun 8, 2018

Uh oh!

Uh oh!

jeromecoutant commented May 31, 2018 •

edited by cmonr

Loading