Skip to content

Windows pytest fixes #7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions tools/test/memap/parse_test.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import sys
from io import open
from os import sep
from os.path import isfile, join, dirname
import json

Expand All @@ -20,9 +21,12 @@
def test_parse_armcc():
memap = MemapParser()
memap.parse(join(dirname(__file__), "arm.map"), "ARM")
assert memap.modules == PARSED_ARM_DATA
memap.parse(join(dirname(__file__), "arm.map"), "UARM")
assert memap.modules == PARSED_ARM_DATA

parsed_data_os_agnostic = dict()
for k in PARSED_ARM_DATA:
parsed_data_os_agnostic[k.replace('/', sep)] = PARSED_ARM_DATA[k]

assert memap.modules == parsed_data_os_agnostic

PARSED_IAR_DATA = {
"startup/startup.o": {".text": 0xc0},
Expand All @@ -35,7 +39,12 @@ def test_parse_armcc():
def test_parse_iar():
memap = MemapParser()
memap.parse(join(dirname(__file__), "iar.map"), "IAR")
assert memap.modules == PARSED_IAR_DATA

parsed_data_os_agnostic = dict()
for k in PARSED_IAR_DATA:
parsed_data_os_agnostic[k.replace('/', sep)] = PARSED_IAR_DATA[k]

assert memap.modules == parsed_data_os_agnostic

PARSED_GCC_DATA = {
"startup/startup.o": {".text": 0xc0},
Expand All @@ -49,9 +58,14 @@ def test_parse_iar():
def test_parse_gcc():
memap = MemapParser()
memap.parse(join(dirname(__file__), "gcc.map"), "GCC_ARM")
assert memap.modules == PARSED_GCC_DATA

parsed_data_os_agnostic = dict()
for k in PARSED_GCC_DATA:
parsed_data_os_agnostic[k.replace('/', sep)] = PARSED_GCC_DATA[k]

assert memap.modules == parsed_data_os_agnostic
memap.parse(join(dirname(__file__), "gcc.map"), "GCC_CR")
assert memap.modules == PARSED_GCC_DATA
assert memap.modules == parsed_data_os_agnostic


def test_add_empty_module():
Expand Down
36 changes: 0 additions & 36 deletions tools/test/test_api/test_api_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,39 +59,3 @@ def test_find_tests_app_config(base_dir, target, toolchain_name, app_config):
"prepare_toolchain was not called with app_config"
assert args[1]['app_config'] == app_config,\
"prepare_toolchain was called with an incorrect app_config"


@pytest.mark.parametrize("build_path", ["build_path"])
@pytest.mark.parametrize("target", ["K64F"])
@pytest.mark.parametrize("toolchain_name", ["ARM"])
@pytest.mark.parametrize("app_config", ["app_config", None])
def test_find_tests_app_config(build_path, target, toolchain_name, app_config):
"""
Test find_tests for correct use of app_config

:param base_dir: dummy value for the test base directory
:param target: the target to "test" for
:param toolchain_name: the toolchain to use for "testing"
:param app_config: Application configuration parameter to find tests
"""
tests = {'test1': 'test1_path','test2': 'test2_path'}
src_paths = ['.']
set_targets_json_location()
with patch('tools.test_api.scan_resources') as mock_scan_resources,\
patch('tools.test_api.build_project') as mock_build_project,\
patch('tools.test_api.get_config') as mock_get_config:
mock_build_project.return_value = "build_project"
mock_scan_resources().inc_dirs.return_value = []
mock_get_config.return_value = ({}, "", "")

build_tests(tests, src_paths, build_path, target, toolchain_name,
app_config=app_config)

arg_list = mock_build_project.call_args_list
for args in arg_list:
assert 'app_config' in args[1],\
"build_tests was not called with app_config"
assert args[1]['app_config'] == app_config,\
"build_tests was called with an incorrect app_config"
mock_get_config.called_with(src_paths, target,
toolchain_name, app_conifg=app_config)
4 changes: 2 additions & 2 deletions tools/test/toolchains/api_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from tools.targets import TARGET_MAP
from tools.notifier.mock import MockNotifier

ALPHABET = [char for char in printable if char not in [u'.', u'/']]
ALPHABET = [char for char in printable if char not in [u'.', u'/', u'\\']]

@given(fixed_dictionaries({
'common': lists(text()),
Expand Down Expand Up @@ -175,7 +175,7 @@ def test_detect_duplicates(filenames):
assert "dupe.c" in notification["message"]
assert "dupe.cpp" in notification["message"]

@given(text(alphabet=ALPHABET + ["/"], min_size=1))
@given(text(alphabet=ALPHABET + [os.sep], min_size=1))
@given(booleans())
@given(booleans())
@settings(max_examples=20)
Expand Down