NXP lpc17xx emac driver #7086

mikaleppanen · 2018-06-01T12:59:53Z

Description

Ported NXP lpc17xx ethernet EMAC driver to unified EMAC.

Related greentea test updates are in: #7103.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

mikaleppanen · 2018-06-01T13:17:20Z

@kjbracey-arm @SeppoTakalo Please review.

kjbracey

Just passing style nits

kjbracey · 2018-06-01T13:42:55Z

features/netsocket/emac-drivers/TARGET_NXP_EMAC/TARGET_LPCTarget/lpc_phy_dp83848.cpp

-	u32_t     phy_speed_100mbs:1; /**< 10/100 MBS connection speed flag. */
-	u32_t     phy_full_duplex:1;  /**< Half/full duplex connection speed flag. */
-	u32_t     phy_link_active:1;  /**< Phy link active flag. */
+	uint32_t     phy_speed_100mbs:1; /**< 10/100 MBS connection speed flag. */


If touching this, that's not technically portable (or sane). Make them bools or unsigned ints.

kjbracey · 2018-06-01T13:45:56Z

features/netsocket/emac-drivers/TARGET_NXP_EMAC/TARGET_LPCTarget/lpc17_emac.cpp

+    idx = LPC_EMAC->TxProduceIndex;
+
+    /* Determine number of free buffers */
+    if (idx == cidx)


{} needed on single lines

kjbracey · 2018-06-04T09:13:09Z

TESTS/network/emac/emac_TestMemoryManager.cpp

@@ -43,12 +48,57 @@

 char s_trace_buffer[100] = MEM_MNGR_TRACE;

+/* For LPC boards define the heap memory bank ourselves to give us section placement
+   control */
+#ifndef ETHMEM_SECTION


If we ever do decide to support Nanostack on this board, let's figure out how to put this somewhere central. But this'll do for test.

Yes, that is true.

0xc0170

why are test changes and new tests part of the porting the driver? I would separate these to do a review of tests and then lpcxx emac driver addition

mikaleppanen · 2018-06-04T10:50:43Z

@0xc0170 Ok, I removed the test changes from this pull request and I'll make a new one for those.

mikaleppanen · 2018-06-04T12:49:36Z

Added support for UBLOX_C027 that was missing from targets.json.

mikaleppanen · 2018-06-04T14:17:55Z

Added missing lwip memory configurations for UBLOX_C027/ARCH_PRO.

SeppoTakalo · 2018-06-05T09:19:01Z

@0xc0170 Please re-review. Changes now done and we would like to push this into next 5.9 patch release, or ever RC (if we still have time).

0xc0170 · 2018-06-06T11:17:58Z

features/netsocket/emac-drivers/TARGET_NXP_EMAC/TARGET_LPCTarget/lpc17_emac.h

@@ -0,0 +1,178 @@
+


license header on top of the file missing

0xc0170 · 2018-06-06T11:19:56Z

Just one small change request and this will go to CI.

When all TX descriptors were reserved in a row so that TX buffer reclaim interrupt did not happen during reservation sequence, after the interrupt occurred, TX buffer reclaim did no longer free buffers. This happened because when all descriptors were in use, last free index pointed to consumed index.

mikaleppanen · 2018-06-06T11:33:41Z

@0xc0170 Added the license.

0xc0170 · 2018-06-07T08:51:46Z

/morph build

mbed-ci · 2018-06-07T12:55:30Z

Build : SUCCESS

Build number : 2267
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7086/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

cmonr · 2018-06-07T16:44:38Z

Halting CI builds until RC3 PRs are completed. Will resume after.

0xc0170 · 2018-06-08T08:15:20Z

/morph test
/morph export-build

mbed-ci · 2018-06-08T15:17:37Z

Exporter Build : SUCCESS

Build number : 1902
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7086/

cmonr · 2018-06-08T15:54:26Z

Pausing CI until 5.9 RC3 completes CI. Will restart jobs when able.

0xc0170 · 2018-06-10T17:38:51Z

/morph build

mbed-ci · 2018-06-10T18:47:50Z

Build : SUCCESS

Build number : 2303
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7086/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-10T20:25:29Z

Exporter Build : SUCCESS

Build number : 1925
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7086/

mbed-ci · 2018-06-10T21:27:59Z

Test : SUCCESS

Build number : 2080
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7086/2080

kjbracey · 2018-06-11T07:33:23Z

This is marked as "refactor", but it's really "fix" as LPC17xx Ethernet is totally nonfunctional in 5.9.0.

adbridge · 2018-06-15T10:40:20Z

Something very weird in this PR!

a5a8b35 this creates a new file and this a840225 modifies and yet they are in the commit list in the opposite order! Which understandably causes havoc with the release script cherry picking them in order!!
I'll try manually applying this as a patch at the end.

kjbracey · 2018-06-15T12:11:21Z

Correct commit order is a508b35, a840225, 4d055ab, 03541df, 97de145. GitHub has reordered the first two.

All 5 commits have the same commit timestamp, from a rebase.

The first two commits have reversed author timestamps - a840225 has an author timestamp earlier than a508b35. That's presumably what's triggered the re-order.

Seems to be a known issue: isaacs/github#386

They actually sort by author-date, not commit-date? Your script re-sorts by commit-date, I believe, but that's ineffective as the commit dates are all equal, because of the rebase.

I think you may need to work around it by asking Git itself for the order. Something like:

git fetch github pull/XXX/head
git rev-list --topo-order mbed-os-5.9..FETCH_HEAD

cmonr · 2018-06-15T15:21:15Z

Wow. That's nuts.

SeppoTakalo previously approved these changes Jun 4, 2018

View reviewed changes

kjbracey previously approved these changes Jun 4, 2018

View reviewed changes

mikaleppanen dismissed stale reviews from kjbracey and SeppoTakalo via a258a33 June 4, 2018 09:42

0xc0170 added the needs: review label Jun 4, 2018

0xc0170 requested changes Jun 4, 2018

View reviewed changes

mikaleppanen mentioned this pull request Jun 4, 2018

Greentea test updated for NXP lpc17xx #7103

Merged

SeppoTakalo previously approved these changes Jun 4, 2018

View reviewed changes

mikaleppanen dismissed SeppoTakalo’s stale review via 8d77606 June 4, 2018 12:47

SeppoTakalo mentioned this pull request Jun 4, 2018

mbed-os-example-sockets not working on UBLOX_C027 ARMmbed/mbed-os-example-sockets#12

Closed

SeppoTakalo previously approved these changes Jun 5, 2018

View reviewed changes

kjbracey previously approved these changes Jun 5, 2018

View reviewed changes

0xc0170 requested changes Jun 6, 2018

View reviewed changes

mikaleppanen dismissed stale reviews from kjbracey and SeppoTakalo via ecaa683 June 6, 2018 11:29

Mika Leppänen added 5 commits June 6, 2018 14:29

Ported NXP LPCxx ethernet driver to unified EMAC

a5a8b35

Added EMAC configuration for UBLOX_C027

4d055ab

Added UBLOX_C027/ARCH_PRO memory configurations

03541df

Added missing license to header of the file

97de145

0xc0170 approved these changes Jun 6, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jun 6, 2018

kjbracey added ready for merge release-version: 5.9.1 and removed needs: CI labels Jun 11, 2018

cmonr merged commit 8c6a664 into ARMmbed:master Jun 11, 2018

0xc0170 removed the ready for merge label Jun 11, 2018

adbridge added release-version: 5.9.1 and removed release-version: 5.9.1 labels Jun 15, 2018

adbridge removed the release-version: 5.9.1 label Jun 15, 2018

adbridge added the release-version: 5.9.1 label Jun 15, 2018

NXP lpc17xx emac driver #7086

NXP lpc17xx emac driver #7086

Uh oh!

Conversation

mikaleppanen commented Jun 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

mikaleppanen commented Jun 1, 2018

Uh oh!

kjbracey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

mikaleppanen commented Jun 4, 2018

Uh oh!

mikaleppanen commented Jun 4, 2018

Uh oh!

mikaleppanen commented Jun 4, 2018

Uh oh!

SeppoTakalo commented Jun 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jun 6, 2018

Uh oh!

mikaleppanen commented Jun 6, 2018

Uh oh!

0xc0170 commented Jun 7, 2018

Uh oh!

mbed-ci commented Jun 7, 2018

Triggering tests

Uh oh!

cmonr commented Jun 7, 2018

Uh oh!

0xc0170 commented Jun 8, 2018

Uh oh!

mbed-ci commented Jun 8, 2018

Uh oh!

cmonr commented Jun 8, 2018

Uh oh!

0xc0170 commented Jun 10, 2018

Uh oh!

mbed-ci commented Jun 10, 2018

Triggering tests

Uh oh!

mbed-ci commented Jun 10, 2018

Uh oh!

mbed-ci commented Jun 10, 2018

Uh oh!

kjbracey commented Jun 11, 2018

Uh oh!

adbridge commented Jun 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kjbracey commented Jun 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Jun 15, 2018

Uh oh!

Uh oh!

mikaleppanen commented Jun 1, 2018 •

edited

Loading

adbridge commented Jun 15, 2018 •

edited

Loading

kjbracey commented Jun 15, 2018 •

edited

Loading