Skip to content

Nanostack EMAC - avoid initialisation race #7121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2018
Merged

Nanostack EMAC - avoid initialisation race #7121

merged 1 commit into from
Jun 11, 2018

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Jun 5, 2018

Description

Hard fault was possible if packet reception occurred during
initialisation. Adjust start-up ordering and add NULL check to
avoid.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@kjbracey
Nanostack EMAC - avoid initialisation race
852445a 
Hard fault was possible if packet reception occurred during
initialisation. Adjust start-up ordering and add NULL check to
avoid.
artokin
artokin approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@artokin artokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hard faults seen anymore during testing (manual & CI)

@kjbracey kjbracey mentioned this pull request Jun 6, 2018
Closed
@kjbracey
Copy link
Contributor Author

kjbracey commented Jun 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2261
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7121/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Exporter Build : FAILURE

Build number : 1886
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7121/

@OPpuolitaival
Copy link
Contributor

Exporter failure seems to be related to s3 connection in jenkins slave. Nothing to do with this change

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Test : SUCCESS

Build number : 2050
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7121/2050

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 8, 2018

Exporter Build : SUCCESS

Build number : 1898
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7121/

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Exporter Build : SUCCESS

Build number : 1911
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7121/

@cmonr cmonr merged commit ef86bf9 into ARMmbed:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@artokin artokin artokin approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kjbracey @mbed-ci @OPpuolitaival @0xc0170 @cmonr @SeppoTakalo @artokin @mikaleppanen