Fix flash_program_page API in LPC boards.

[davidsaada]

Description

This PR fixes the flash_program_page API in LPC boards.
This API allocates a program buffer of 256 on the stack to ensure alignment.
However, FlashIAP driver already ensures this alignment of the user data, so this allocation is redundant.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

[mmahadevan108]

Agree. This operation is redundant as a check is present in the driver to ensure address is page aligned.

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2320
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7128/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1942
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7128/

[mbed-ci]

Test : FAILURE

Build number : 2098
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7128/2098

[0xc0170]

@davidsaada The latest commit fixes the test failure (helps if you comment on any change in the PR to provide actual status)

[davidsaada]

(@0xc0170 was just about to - you beat me up to it...)
Removed a test checking that programming succeeds if buffer is unaligned in the hal level, which is just what this fix changes.

[0xc0170]

Just to confirm - the headline is for LPC fix but I can see functional test case removal - is this because test is actually always passed or ?

[davidsaada]

Just to confirm - the headline is for LPC fix but I can see functional test case removal - is this because test is actually always passed or ?

It is because FlashIAP makes sure that user data is aligned, no need to take care of it in HAL layer (which is what the test checked). LPC allocated a lot of stack for this purpose (keeping user data aligned at HAL layer), which is exactly what this PR fixed.

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2352
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7128/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1976
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7128/

[mbed-ci]

Test : SUCCESS

Build number : 2138
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7128/2138