Kinetis EMAC: Make number of buffers configurable #7141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FAO @mmahadevan108 |
kjbracey
force-pushed
the
kinetis-mem-conf
branch
from
a4c32f6 to
eea7a98
Compare
16 RX buffers and 8 TX buffers is probably excessive. Nanostack version of driver successfully used 4+4, and data pump should be broadly equivalent. This means that switching K64F devices from Nanostack to EMAC increases base heap usage by 18K - observed in Nanostack border router builds. Add a config option to make it possible to lower the number of buffers. Defer consideration of lowering the default to later.
TX pointer array was using RX ring length in its declaration. Wasted memory if RX ring > TX ring, as is the default, but would be broken if RX ring < TX ring.
kjbracey
force-pushed
the
kinetis-mem-conf
branch
from
eea7a98 to
a8e8775
Compare
mikaleppanen
approved these changes
Jun 6, 2018
SeppoTakalo
approved these changes
Jun 6, 2018
mmahadevan108
approved these changes
Jun 6, 2018
|
/morph build |
Build : SUCCESSBuild number : 2262 Triggering tests/morph test |
artokin
approved these changes
Jun 7, 2018
Exporter Build : FAILUREBuild number : 1888 |
|
Halting CI builds until RC3 PRs are completed. Will resume after. |
|
/morph test |
Test : SUCCESSBuild number : 2057 |
Exporter Build : SUCCESSBuild number : 1897 |
0xc0170
approved these changes
Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
16 RX buffers and 8 TX buffers is probably excessive. Nanostack version of driver ( https://github.com/ARMmbed/sal-nanostack-driver-k64f-eth ) successfully used 4+4, and data pump should be broadly equivalent.
This means that switching K64F devices from Nanostack to EMAC for 5.9 increases base heap usage by 18K - observed in Nanostack border router builds.
Add a config option to make it possible for border router and others to lower the number of buffers.
Defer consideration of lowering the default to later - leaving it as 16+8 for now.
Pull request type