Skip to content

Tool, build_release: Return nonzero when builds fail #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

It looks like this script will incorrectly report build failures and script
bugs as a pass. This patch should resolve that.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr
cmonr previously approved these changes Jun 6, 2018
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small and simple.

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2018

Build : SUCCESS

Build number : 2254
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7148/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

0xc0170
0xc0170 previously approved these changes Jun 7, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2018

mbed 2 build failed, please review. I can see an error there, plus that it does not build anything build_mbed_libs() got an unexpected keyword argument 'verbose'

OPpuolitaival
OPpuolitaival previously approved these changes Jun 7, 2018
@theotherjimmy
Copy link
Contributor Author

@0xc0170 Yeah, it needs a rebase after my other Mbed 2 PR.

@theotherjimmy theotherjimmy dismissed stale reviews from OPpuolitaival, 0xc0170, and cmonr via 427d8c2 June 7, 2018 13:55
@theotherjimmy theotherjimmy force-pushed the nonzero-build-release branch from d4a13b6 to 427d8c2 Compare June 7, 2018 13:55
@theotherjimmy
Copy link
Contributor Author

Rebase done. Please review.

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

Halting CI builds until RC3 PRs are completed. Will resume after.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2018

/morph build

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Build : SUCCESS

Build number : 2299
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7148/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 10, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 11, 2018

@theotherjimmy @OPpuolitaival As far as y'all know, this is only used internally, correct? If so, this can be relabeled back to 5.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants