-
Notifications
You must be signed in to change notification settings - Fork 3k
Tool, build_release: Return nonzero when builds fail #7148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small and simple.
/morph build |
Build : SUCCESSBuild number : 2254 Triggering tests/morph test |
Test : SUCCESSBuild number : 2043 |
Exporter Build : SUCCESSBuild number : 1879 |
mbed 2 build failed, please review. I can see an error there, plus that it does not build anything |
@0xc0170 Yeah, it needs a rebase after my other Mbed 2 PR. |
427d8c2
d4a13b6
to
427d8c2
Compare
Rebase done. Please review. |
/morph build |
Halting CI builds until RC3 PRs are completed. Will resume after. |
/morph build |
1 similar comment
/morph build |
Build : SUCCESSBuild number : 2299 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1921 |
Test : SUCCESSBuild number : 2075 |
@theotherjimmy @OPpuolitaival As far as y'all know, this is only used internally, correct? If so, this can be relabeled back to 5.9.1. |
Description
It looks like this script will incorrectly report build failures and script
bugs as a pass. This patch should resolve that.
Pull request type