Skip to content

BLE: fix pairing for misconfigured devices (deny pairing correctly) #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2018
Merged

BLE: fix pairing for misconfigured devices (deny pairing correctly) #7166

merged 1 commit into from
Jun 13, 2018

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jun 7, 2018 •
edited
Loading

Description

Under certain circumstances when SC is not supported but required when pairing is requested this would send a reject (correctly) but also potentially accept at the same time because the function is missing a return that was intended to be there. The pairing would still fail but incorrect events and messages would be sent. This stops it.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@paul-szczepanek-arm
missing return
bd8572e 
function would potentially send a reject and accept at the same time
@paul-szczepanek-arm paul-szczepanek-arm requested a review from pan- June 7, 2018 16:28
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2018

Can you name this PR (fix the title, used in the release notes).

@paul-szczepanek-arm paul-szczepanek-arm changed the title missing return BLE: fix pairing for misconfigured devices (deny pairing correctly) Jun 11, 2018
@paul-szczepanek-arm
Copy link
Member Author

apologies, did mean to do that

donatieng
donatieng approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cmonr
Copy link
Contributor

cmonr commented Jun 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

Build : SUCCESS

Build number : 2326
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7166/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

Exporter Build : SUCCESS

Build number : 1948
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7166/

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2018

Test : SUCCESS

Build number : 2106
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7166/2106

@cmonr cmonr merged commit fff3564 into ARMmbed:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@pan- pan- pan- approved these changes

@donatieng donatieng donatieng approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@paul-szczepanek-arm @0xc0170 @cmonr @mbed-ci @pan- @donatieng @NirSonnenschein