Skip to content

adding USTICKER label in C027 device has: #7169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 56 commits into from
Closed

adding USTICKER label in C027 device has: #7169

wants to merge 56 commits into from

Conversation

aqib-ublox
Copy link
Contributor

Description

Added a label USTICKER for C027 as us_ticker new implemnaation is adopted for LPC176x targets and locally tests are passing with this changeset.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@aqib-ublox
Copy link
Contributor Author

log.txt
Toolchain: GCC_ARM
Tests: All
Target: C027

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2018

awesome to review logs here as well, IAR and ARMCC tested?

@aqib-ublox
Copy link
Contributor Author

let me add ARM and IAR test log as well
log_iar.txt
Toolchain: IAR
Tests: All
Target: C027

log_arm.txt
Toolchain: ARM
Tests: All
Target: C027

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 10, 2018

Build : SUCCESS

Build number : 2306
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7169/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 10, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 11, 2018

@kjbracey
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Jun 11, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 11, 2018

/morph mbed2-build

0xc0170
0xc0170 previously approved these changes Jun 11, 2018
@cmonr
Copy link
Contributor

cmonr commented Jun 12, 2018

That's a shame. This is going to need a rebase.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2018

This seems to be rebased but for one definition addition 4 commits, can you squash it into one please?

@aqib-ublox
Copy link
Contributor Author

i will try but commits are non-contiguous so would it be possible to squash into one?

@cmonr
Copy link
Contributor

cmonr commented Jun 13, 2018

@aqib-ublox It should be fine. Imaginge your branch as a set of diffs applied one at a time.

A quick way to do the squash would be to do a soft reset to the head of the base commit of the branch, keeping your changes intact but allowing you to gather all of the changes in a single commit.

@aqib-ublox
Copy link
Contributor Author

@cmonr you suggested a solution but again i want to say commits are non-contigous i can only combine last two commits plz see commits.txt
Head commit rev: dc3ecf011, 2nd last rev: 20fa76b1e but 1st commit is at rev: 0d478ba in b/w 1st and 2nd commit i have number of commits so if i do git reset --soft fd6f3cd(commit before 1st) all in b/w commits would also be pushed to staging and become part of this commit which result in loosing rev history, plz guide if i am wrong
commits.txt

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2018

@aqib-ublox Looking at the changes here. they are quite small, 1 line affected, might be easiest to reset your branch (hard one) and create a new commit. (I noticed you also removed EMAC? bad conflict resolution?)

Let's just do not spend more time for something that simple.

Krzysztof Stachowiak and others added 5 commits June 21, 2018 15:29
Nanostack object constructor didn't actually initialise Nanostack.
Nanostack initialisation was deferred until an interface was actually
attached to the stack, which generally happened at first interface
connect.

Not normally a problem, unless you're trying to make direct Nanostack
setup calls prior to connect - some applications do this, and were
relying on ThreadInterface::initialise to do Nanostack
initialisation.

Unfortunately in 5.9 ThreadInterface::initialise no longer does
initialise Nanostack immediately, because the mesh interfaces were
aligned and integrated with the Ethernet interfaces, which did
initialisation on connect().

Make the Nanostack object constructor initialise Nanostack (as the LWIP
constructor does for lwIP), so calling Nanostack::get_instance() is the
5.9 API for Nanostack initialisation.

For future work, APIs like ns_file_system_set_root_path should be
exposed as methods of Nanostack, so everything happens with a single
Nanostack::get_instance().file_system_set_root_path().
 ### Description
Full paths in the map file are required to have correct memap parsing.
This PR adds the option `--show_full_path` to ARMC6 in every profile.
This option only affects the map file output, so it's safe to add.
Teppo Järvelin and others added 27 commits June 21, 2018 15:33
- set ppp_active false if close fails in ppp disconnect.
- unset sigio in ppp disconnect
- take ownership of filehandle in CellularNetwork::disconnect even in case of failure
Update test configuration file for WicedInterface
The nrf section features has different implementations for each compilers supported by mbed-os. The header guard was ruling out compiler other than GCC by checking if __GNUC__ is defined. This check is not applicable on mbed os as the ARM compiler compile sources with gnu compatibility.

This patch makes sure that the right implementation is selected for the right compiler . The previous patch has been reverted as it is not reliable.
- Remove calls to HAL_SuspendTick and HAL_ResumeTick
- Rename stm_common.c in hal_tick_common.c
Updated EMAC memory manager to use libservice nsdynmemlib
for EMAC memory buffers. Located the nsdynmemlib buffer heap
to DMA safe memory bank on LPCxx boards. Optimized placement of
static variables on EMAC test environment for LPCxx boards to
maximize available memory.
Changed RX and TX buffers used in TCP socket tests to global variables
to conserve memory.
…orm: MCU_NRF51_16K_UNIFIED_S130

Add target definition for Raytac MDBT40 module to use the MCU_NRF51_16K_UNIFIED_S130 target.
Previously get_mac_address on a ThreadInterface returned the EUI-64
reported by the radio driver. This was required for commissioning, but
was inconsistent with other interfaces, and the API concept.

5.9.0 inadvertently changed this so that get_mac_address returned the
actual MAC address used by the radio, which is a hash result of the
EUI-64 for Thread.

The original "return the EUI-64" form was somewhat faulty, as
get_mac_address would not return the EUI-64 set by set_device_eui64() or
another mechanism before connect() was called.

Rather than revert to old behaviour, add a new API to get the device
EUI-64 to ThreadInterface, alongside the existing set API.
Set correct SYSMPU register for proper USB operation.  This bug was
introduced when the SYSMPU register names and defines were updated
in the commit:
"K64F: Updated the SYSMPU SDK driver"
93f8cfe
Share IPv6 conversion code with mbed_trace, Nanostack and
mbed client.

Output formatting is better, being conformant to RFC 5952.
Two cascading copy-paste errors stopped this working:

  * PPPCellularInterface::get_gateway() called
    nsapi_ppp_get_ip_address();
  * nsapi_ppp_get_gateway() called the interface's get_netmask().

First bug has always been there - second one was introduced in 5.9.

AT_CellularNetwork currently lacks calls to get both netmask and gateway
- this patch would be needed for that when added.
@aqib-ublox
Copy link
Contributor Author

#7291 closing PR and open other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.