LoRaWAN: Fine tuning timing for delays and receive windows #7191
Conversation
RX1 and 2 delays needed to be more precise and aggregate tx time was drifiting because of timing difference between actual tx interrupt and our processing of that interrupt ever so slightly. We now take a timestamp of the tx interrupt and take a time diff while instantiating delay timers. The timestamp is then used to update the aggregate tx time. Two new methods are introduced in the LoRaMac class which provide current timing and current receive slot. These functions are used by LoRaWANStack for its processing.
|
@kjbracey-arm @AnttiKauppila @cmonr @0xc0170 Please review. |
hasnainvirk
force-pushed
the
precise_timing
branch
from
b7a7ceb to
8c9df0b
Compare
|
/morph build |
Build : SUCCESSBuild number : 2349 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1973 |
If the automatic uplink is sent directly the call-stack becomes larger than 1K which may cause serious problems in debug builds. Just to have a respite between RX and TX we queue an event for the automatic uplink rather than directly undergoing an automatic uplink.
We must check for a valid value of a frequency being sent by the network server.
hasnainvirk
force-pushed
the
precise_timing
branch
from
8c9df0b to
d335f82
Compare
|
@kjbracey-arm @AnttiKauppila Please review. |
Test : SUCCESSBuild number : 2134 |
|
/morph build |
Build : SUCCESSBuild number : 2378 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2011 |
Test : SUCCESSBuild number : 2167 |
|
@cmonr @kjbracey-arm Please review and merge. |
Description
This PR mainly focuses on making the timing behaviour for delays and receive windows a touch better.
In the previous incarnations of the code base, as nobody else was using the main event queue, we got away with the problems. But we may encounter them if the application does some expansive operations on the event queue. We now take a timestamp at the moment the tx interrupt happens after which we are supposed to indulge into delays and opening of receive windows. Then we take a diff of time passed in between the tx interrupt and our processing time and hence we tend towards more precise timing overall.
Automatic uplink was being triggered right in the reception sequence and that was causing the call stack to be really cumbersome especially in debug builds. So to counter that, we now queue a call for automatic uplink rather than directly doing an uplink.
Two new APIs are introduced in LoRaMac class (an internal class) which provide current timing and receive slot information to the controller, i.e., LoRaWANStack.
Target Release Version : 5.9.1
Pull request type