Skip to content

STM32: Fix data alignment issue in HASH function for F2, F7, L4 #7205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Jun 13, 2018

Description

This PR fixes an issue with data alignment in ST HAL hash write data function.

This is the same change has the one done in PR #7176 and it fixes Issue #7188.

@KariHaapalehto can you please review it and tell me which test(s) did you use to verify it on the STM32F4 ?

cc @ARMmbed/team-st-mcd for review also

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team June 13, 2018 11:29
@KariHaapalehto
Copy link
Contributor

Looks good to me +1.
ARM had a internal issue found in internal testing with mbed cloud client.
I ran internal testcase with GCC_ARM, ARM and IAR compilers with both release and debug profiles to verify fix

@0xc0170 0xc0170 requested a review from KariHaapalehto June 13, 2018 12:44
@cmonr
Copy link
Contributor

cmonr commented Jun 19, 2018

@ARMmbed/team-st-mcd Are y'all alright with the changes?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2387
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7205/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 20, 2018

Holding to wait for feedback from @ARMmbed/team-st-mcd, just in case.
Otherwise, this should be good to go.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcostm is ST team :-)

@bcostm
Copy link
Contributor Author

bcostm commented Jun 20, 2018

I agree with myself :) No seriously, we need to be coherent. This patch has been added for the F4 devices, so there is no reason to not add it for other STM32 devices... Otherwise we need to revert the F4 patch ...

@cmonr cmonr merged commit cc1e4f0 into ARMmbed:master Jun 20, 2018
@bcostm bcostm deleted the fix_hash_data_alignment branch July 16, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants