Skip to content

Disable XTS cipher mode by default when importing Mbed TLS #7243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2018
Merged

Disable XTS cipher mode by default when importing Mbed TLS #7243

merged 1 commit into from
Jun 25, 2018

Conversation

k-stachowiak
Copy link
Contributor

@k-stachowiak k-stachowiak commented Jun 18, 2018 •
edited by cmonr
Loading

Description

This PR updates the Mbed TLS import scripts so that the XTS cipher mode option is disabled by default.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@cmonr cmonr requested a review from a team June 18, 2018 18:19
@cmonr cmonr requested review from mazimkhan and hanno-becker and removed request for a team June 18, 2018 18:21
mazimkhan
mazimkhan approved these changes Jun 20, 2018
View reviewed changes
Copy link

@mazimkhan mazimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonbutcher
Copy link
Contributor

@cmonr - This needs to be reviewed by someone on the @ARMmbed/mbed-os-crypto team. @hanno-arm and @mazimkhan are both on the TLS team.

cc: @Patater

@cmonr
Copy link
Contributor

cmonr commented Jun 22, 2018

@sbutcher-arm Thanks for the fyi.

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

Build : SUCCESS

Build number : 2435
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7243/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

Exporter Build : SUCCESS

Build number : 2067
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7243/

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

Test : SUCCESS

Build number : 2215
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7243/2215

@cmonr cmonr merged commit dd7555e into ARMmbed:master Jun 25, 2018
@mazimkhan mazimkhan mentioned this pull request Aug 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@Patater Patater Patater approved these changes

@mazimkhan mazimkhan mazimkhan approved these changes

@hanno-becker hanno-becker Awaiting requested review from hanno-becker

Assignees
No one assigned
Labels
component: security release-version: 5.10.0-rc1 tracking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@k-stachowiak @simonbutcher @cmonr @mbed-ci @Patater @mazimkhan @0xc0170