Skip to content

Remove endpoint parameter from USB callbacks #7267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Jun 19, 2018

Description

Remove the endpoint parameter from endpoint callbacks. This
information is redundant because endpoints are known at construction time because they must be in the configuration descriptor.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[x] Breaking change

Remove the endpoint parameter from endpoint callbacks. This
information is redundant because endpoints are known at
construction time because they must be in the configuration
descriptor.
@c1728p9 c1728p9 requested review from cmonr and fkjagodzinski June 19, 2018 23:25
@c1728p9
Copy link
Contributor Author

c1728p9 commented Jun 19, 2018

This page will need to be updated to reflect this API change:
https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/reference/technology/USB.md

Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine.

@cmonr
Copy link
Contributor

cmonr commented Jun 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 20, 2018

Build : SUCCESS

Build number : 2403
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7267/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 20, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 20, 2018

@cmonr cmonr merged commit db3a435 into ARMmbed:feature-hal-spec-usb-device Jun 20, 2018
@0xc0170 0xc0170 removed the needs: CI label Jun 20, 2018
fkjagodzinski added a commit to fkjagodzinski/mbed-os that referenced this pull request Jul 3, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in ARMmbed#7267.
0xc0170 pushed a commit that referenced this pull request Jul 18, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
c1728p9 pushed a commit that referenced this pull request Jul 31, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
c1728p9 pushed a commit that referenced this pull request Oct 3, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
c1728p9 pushed a commit that referenced this pull request Nov 2, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
juhaylinen pushed a commit to juhaylinen/mbed-os that referenced this pull request Nov 12, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in ARMmbed#7267.
cmonr pushed a commit that referenced this pull request Nov 29, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
cmonr pushed a commit that referenced this pull request Dec 4, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
c1728p9 pushed a commit that referenced this pull request Dec 19, 2018
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
c1728p9 pushed a commit to c1728p9/mbed-os that referenced this pull request Jan 17, 2019
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in ARMmbed#7267.
c1728p9 pushed a commit that referenced this pull request Jan 29, 2019
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in #7267.
c1728p9 pushed a commit to c1728p9/mbed-os that referenced this pull request Feb 22, 2019
Endpoint callbacks no longer have endpoint as a param. This update was
introduced in ARMmbed#7267.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants