Skip to content

Cellular: fixed defect where SIM interface was closed too early #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2018
Merged

Cellular: fixed defect where SIM interface was closed too early #7275

merged 2 commits into from
Jun 22, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Jun 20, 2018

Description

SIM interface was closed too early in CellularConnectionFSM.cpp causing a crash if APN lookup was enabled and apn configured to '0' in application json.
Crash happened EasyCellularConnection::connect(). Moved SIM interface closing a bit later.

Internal ref to defect: IOTCELL-1122

@AriParkkila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

AriParkkila
AriParkkila previously approved these changes Jun 20, 2018
View reviewed changes
Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please push also to mbed-os-5.9

0xc0170
0xc0170 previously approved these changes Jun 20, 2018
View reviewed changes
@0xc0170 0xc0170 requested a review from AnotherButler June 20, 2018 11:52
@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

@jarvte @AriParkkila We're a bit confused. As is, this PR look like it will be going into 5.9.2.
Are y'all saying that this should instead be going to 5.10?

Copy edit CellularConnectionFSM.h
da6f2d9 
Copy edit for consistent tense and comma usage.
@AnotherButler AnotherButler dismissed stale reviews from 0xc0170 and AriParkkila via da6f2d9 June 21, 2018 16:12
@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2018

Build : SUCCESS

Build number : 2422
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7275/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2018

Exporter Build : SUCCESS

Build number : 2052
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7275/

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

Test : SUCCESS

Build number : 2203
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7275/2203

@cmonr cmonr merged commit 85f66ca into ARMmbed:master Jun 22, 2018
@0xc0170 0xc0170 removed the needs: CI label Jun 22, 2018
@AriParkkila
Copy link

@cmonr this fix should be good for all 5.9, 5.10 and master.

@AriParkkila AriParkkila mentioned this pull request Jun 25, 2018
Closed
@jarvte jarvte deleted the fix_sim_null_when_used branch October 22, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

@AriParkkila AriParkkila AriParkkila left review comments

@AnotherButler AnotherButler Awaiting requested review from AnotherButler

Assignees
No one assigned
Labels
release-version: 5.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jarvte @cmonr @mbed-ci @AriParkkila @0xc0170