Made saml21 target run on mbed5 #7276

martinichka · 2018-06-20T11:52:06Z

Description

Last bits to make SAM L21 being supported in mbed5 (mbed2 was already working fine).

Open issues:

rtos not supported yet, needed to be compiled with the following mbedignore:

mbed-os/rtos/*
mbed-os/features/filesystem/*
mbed-os/features/nvstore/*
mbed-os/features/cellular/*
mbed-os/features/frameworks/*
mbed-os/features/net/*
mbed-os/features/netsocket/*
mbed-os/features/storage/*

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

martinichka · 2018-06-20T17:59:46Z

@0xc0170 and @ashok-rao this PR was requested by @janjongboom

ashok-rao · 2018-06-22T08:38:45Z

targets/targets.json

@@ -3366,7 +3366,7 @@
    "SAML21J18A": {
        "inherits": ["Target"],
        "core": "Cortex-M0+",
-        "macros": ["__SAML21J18A__", "I2C_MASTER_CALLBACK_MODE=true", "EXTINT_CALLBACK_MODE=true", "USART_CALLBACK_MODE=true", "TC_ASYNC=true"],
+        "macros": ["__SAML21J18A__", "I2C_MASTER_CALLBACK_MODE=true", "EXTINT_CALLBACK_MODE=true", "USART_CALLBACK_MODE=true", "TC_ASYNC=true", "CMSIS_VECTAB_VIRTUAL", "CMSIS_VECTAB_VIRTUAL_HEADER_FILE=\"cmsis_nvic.h\""],
        "extra_labels": ["Atmel", "SAM_CortexM0P", "SAML21"],


release_versions is missing if you want to add support for OS 5. Also, why RTOS support is removed via .mbedignore?

why RTOS support is removed via .mbedignore?

as we don't use RTOS for our project and it was failing with:

Compile [ 0.3%]: main.cpp [Fatal Error] mbed_rtx_conf.h@25,22: mbed_rtx.h: No such file or directory [ERROR] In file included from ./mbed-os/rtos/TARGET_CORTEX/rtx5/RTX/Config/RTX_Config.h:31:0, from ./mbed-os/rtos/TARGET_CORTEX/rtx5/RTX/Include/rtx_evr.h:31, from ./mbed-os/rtos/TARGET_CORTEX/rtx5/RTX/Source/rtx_lib.h:38, from ./mbed-os/rtos/TARGET_CORTEX/mbed_rtos_storage.h:43, from ./mbed-os/rtos/rtos.h:28, from ./mbed-os/mbed.h:20, from ./main.cpp:1: ./mbed-os/rtos/TARGET_CORTEX/mbed_rtx_conf.h:25:22: fatal error: mbed_rtx.h: No such file or directory #include "mbed_rtx.h" ^ compilation terminated.

bulislaw · 2018-06-22T12:53:11Z

Once you get the RTOS sorted, could you post results of mbed test -v (depending on your env settings you may need to set the compiler and targets), just the test results not the whole dump.

janjongboom · 2018-06-23T11:01:07Z

There will be a follow up PR with RTOS support. Do you want to hold off from landing this before it's sorted out?

cmonr · 2018-06-25T15:40:24Z

@janjongboom In order for this to pass tests in Mbed 5, RTOS support is needed.

martinichka · 2018-06-25T20:29:10Z

I added mbed_rtx.h for saml21. With stack pointer to end of ram. Base address is 0x20000000 and ram size is 32k I set it to 0x20008000UL. That should be all isn't it? It is still untested. I will test it in the coming days (it is a side project for me).

The only file I needed to put into mbedignore to make it compile is:
mbed-os/features/filesystem/bd/MBRBlockDevice.cpp
otherwise it fails with:

[ERROR] In file included from /opt/gcc-arm-none-eabi-6_2-2016q4/arm-none-eabi/include/c++/6.2.1/algorithm:61:0,
                 from ./mbed-os/features/filesystem/bd/MBRBlockDevice.cpp:18:
/opt/gcc-arm-none-eabi-6_2-2016q4/arm-none-eabi/include/c++/6.2.1/bits/stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2
     min(const _Tp& __a, const _Tp& __b, _Compare __comp)

Any ideas what issue that might be?

martinichka · 2018-06-25T21:11:50Z

Running mbed test -v fails with the same error about min/max

martinichka · 2018-06-25T21:56:10Z

After removing the conflicting math macros I can compile without mbedignores. Now the test tries to connect the device, which obviously does not succeed because it don't have it here with me at the moment. @0xc0170 and @ashok-rao But how it would find the device? How does this work and how can I make it supported?

cmonr · 2018-06-25T22:06:21Z

@martinichka The tool that we use to detect targets is called mbed-ls.

You should submit a PR here: https://github.com/ARMmbed/mbed-ls/pulls

cmonr · 2018-07-03T12:47:45Z

@martinichka Any updates? Need any help anywhere?

martinichka · 2018-07-04T05:47:03Z

No updates yet, sorry. I had no time to work on it yet . The board I need to enable is https://www.microchip.com/developmenttools/ProductDetails/atsaml21-xpro-b What would be the steps I should take to make it compatible with mbed-ls?

…

On Tue, 3 Jul 2018 at 14:47, Cruz Monrreal ***@***.***> wrote: @martinichka <https://github.com/martinichka> Any updates? Need any help anywhere? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7276 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJnOlS8t3RWP9J_55wViGtQlw8pvbY9Yks5uC2f6gaJpZM4UvH-F> .

cmonr · 2018-07-26T16:36:57Z

@martinichka You'll need to open a pull request to https://github.com/ARMmbed/mbed-ls and add support for your board. Once it's in and mbed-ls has been released, then we can update CI with the latest version and revisit this PR.

janjongboom · 2018-08-03T13:16:45Z

@martinichka When running with RTOS on it errors out for me at Mutex 0x20000c94 error -8: Unknown. Have you seen that before?

janjongboom · 2018-08-03T13:45:54Z

The gpio_api.c gpio_init implementation is not correct. The MBED_ASSERT should be removed, it's fine to declare a NC pin as gpio, it should just call return. This is in line with other HAL implementations.

diff --git a/targets/TARGET_Atmel/TARGET_SAM_CortexM0P/gpio_api.c b/targets/TARGET_Atmel/TARGET_SAM_CortexM0P/gpio_api.c
index 2706e3cfb..256ad2f32 100644
--- a/targets/TARGET_Atmel/TARGET_SAM_CortexM0P/gpio_api.c
+++ b/targets/TARGET_Atmel/TARGET_SAM_CortexM0P/gpio_api.c
@@ -28,14 +28,14 @@ uint32_t gpio_set(PinName pin)

 void gpio_init(gpio_t *obj, PinName pin)
 {
-    MBED_ASSERT(pin != (PinName)NC);
+    if (pin == (PinName)NC)
+        return;
+
     struct port_config pin_conf;
     PortGroup *const port_base = (PortGroup*)port_get_group_from_gpio_pin(pin);

     obj->pin = pin;
-    if (pin == (PinName)NC)
-        return;
-
     obj->mask = gpio_set(pin);
     port_get_config_defaults(&pin_conf);
     obj->powersave = pin_conf.powersave;

martinichka · 2018-08-03T14:05:21Z

I have not run it with RTOS, so no

…

On Fri, 3 Aug 2018 at 15:39, Jan Jongboom ***@***.***> wrote: @martinichka <https://github.com/martinichka> When running with RTOS on it errors out for me at Mutex 0x20000c94 error -8: Unknown. Have you seen that before? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7276 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJnOlbdjSVCO-DR9F1vrRsV9JWXuXiloks5uNFKAgaJpZM4UvH-F> .

janjongboom · 2018-08-08T14:39:36Z

@martinichka FYI, ARMmbed/mbed-ls#384 - will take a stab at it next week.

cmonr · 2018-08-24T05:24:22Z

@martinichka @janjongboom Any updates?

janjongboom · 2018-09-03T04:28:54Z

@cmonr No, unfortunately not; and I don't have the target with me right now...

janjongboom · 2018-09-05T04:21:05Z

@cmonr @martinichka mbed-ls PR is now open ARMmbed/mbed-ls#390

Trying to run the tests but nothing seems to run on the fresh board that I got... Will check when back in Netherlands.

janjongboom · 2018-10-10T09:18:54Z

@martinichka RTOS working here: https://github.com/janjongboom/mbed-os/tree/feature-saml21-mbed5-rebased - now about to run the tests.

cmonr · 2018-10-23T00:50:24Z

@janjongboom Any update on the tests?

0xc0170 · 2018-10-23T09:22:44Z

@martinichka RTOS working here: https://github.com/janjongboom/mbed-os/tree/feature-saml21-mbed5-rebased - now about to run the tests.

As this require further work, please update us (reopen pull request once there is an update we can review). In the meantime, we close this PR due to inactivity.

janjongboom · 2018-10-24T02:29:13Z

@cmonr Yes, some issues with the test runner on the board. Just hangs sometimes, that makes it hard. Will get back to this when back from travelling.

Marten Lootsma added 2 commits June 20, 2018 13:43

Added support for dynamic vector table

5fcd786

Added missing fire interrupt function

89f372c

0xc0170 added the needs: review label Jun 20, 2018

0xc0170 requested a review from ashok-rao June 20, 2018 11:53

ashok-rao reviewed Jun 22, 2018

View reviewed changes

cmonr added needs: work and removed needs: review labels Jun 22, 2018

Set release_versions for SAML21

ec1bf4a

Added mbed_rtx.h for saml21

11ed24d

Removed conflicting 'math' macros

cf8926d

janjongboom mentioned this pull request Sep 5, 2018

Add support for XPLAINED PRO SAML21 board ARMmbed/mbed-ls#390

Merged

janjongboom mentioned this pull request Sep 14, 2018

SAML21: HardFault on SysTick_Handler #8135

Closed

0xc0170 closed this Oct 23, 2018

0xc0170 removed the needs: work label Oct 23, 2018

janjongboom mentioned this pull request Nov 6, 2018

Update SAML21J18A target to Mbed OS 5.12 #8658

Closed

Made saml21 target run on mbed5 #7276

Made saml21 target run on mbed5 #7276

Uh oh!

Conversation

martinichka commented Jun 20, 2018

Description

Pull request type

Uh oh!

martinichka commented Jun 20, 2018

Uh oh!

ashok-rao Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

martinichka Jun 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bulislaw commented Jun 22, 2018

Uh oh!

janjongboom commented Jun 23, 2018

Uh oh!

cmonr commented Jun 25, 2018

Uh oh!

martinichka commented Jun 25, 2018

Uh oh!

martinichka commented Jun 25, 2018

Uh oh!

martinichka commented Jun 25, 2018

Uh oh!

cmonr commented Jun 25, 2018

Uh oh!

cmonr commented Jul 3, 2018

Uh oh!

martinichka commented Jul 4, 2018 via email

Uh oh!

cmonr commented Jul 26, 2018

Uh oh!

janjongboom commented Aug 3, 2018

Uh oh!

janjongboom commented Aug 3, 2018

Uh oh!

martinichka commented Aug 3, 2018 via email

Uh oh!

janjongboom commented Aug 8, 2018

Uh oh!

cmonr commented Aug 24, 2018

Uh oh!

janjongboom commented Sep 3, 2018

Uh oh!

janjongboom commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janjongboom commented Oct 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Oct 23, 2018

Uh oh!

0xc0170 commented Oct 23, 2018

Uh oh!

janjongboom commented Oct 24, 2018

Uh oh!

Uh oh!

martinichka Jun 23, 2018 •

edited

Loading

janjongboom commented Sep 5, 2018 •

edited

Loading

janjongboom commented Oct 10, 2018 •

edited

Loading