Skip to content

On STM32F439xI IAR linker file decreased stack size and increased heap #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2018
Merged

On STM32F439xI IAR linker file decreased stack size and increased heap #7289

merged 1 commit into from
Jul 31, 2018

Conversation

mikaleppanen
Copy link

@mikaleppanen mikaleppanen commented Jun 21, 2018 •
edited
Loading

Description

On STM32F439xI IAR linker file decreased stack size from 24kbytes to 1kbytes (stack is used on boot-up/interrupt handler). Increased heap size from 65kbytes to 89kbytes.

Change is related to issue #7137 where UBLOX_EVK_ODIN_W2 runs out of heap on WLAN.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mikaleppanen mikaleppanen mentioned this pull request Jun 21, 2018
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2018

@ARMmbed/team-ublox Please review

cc @ARMmbed/team-st-mcd

@adbridge adbridge requested a review from a team June 21, 2018 11:45
bulislaw
bulislaw previously requested changes Jun 22, 2018
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are unifying ISR stack sizes to 1K across the boards (there are some exceptions Cortex A and NRF). Could you go straight to 1K please.

@bulislaw
Copy link
Member

#7238 changes to stack sizes and tests

On STM32F439xI IAR linker file decreased stack size and increased heap
50a130b 
Decreased stack size from 24kB to 1kB (stack is used on boot-up/interrupt
handler). Increased heap size from 65kB to 89kB.

Change is related to issue #7137
where UBLOX_EVK_ODIN_W2 runs out of heap on WLAN.
@mikaleppanen
Copy link
Author

Changed stack size to 1K.

@asifrizwanubx
Copy link
Contributor

asifrizwanubx commented Jun 26, 2018 •
edited
Loading

why was the stack size earlier 24K?

@screamerbg
Copy link
Contributor

@mikaleppanen Could you please answer the question above so we could progress with the PR?

@mikaleppanen
Copy link
Author

@asifrizwanubx I do now know details. Looks like they were set to some default values based on memory size.

@asifrizwanubx
Copy link
Contributor

is there any possiblity that this change will effect the behaviour of wifi drivers? I will test this PR with ublox internal tests and let you know if there is something wrong.

@mikaleppanen
Copy link
Author

@asifrizwanubx Ok, that sounds good. Change will affect ISR stack that is now 1K.

@SeppoTakalo
Copy link
Contributor

@bulislaw Please review again, so this PR can proceed. Stack size have been changed as you requested.

@asifrizwanubx
Copy link
Contributor

@mikaleppanen I have verifeid this and there is no bad impact on ublox internal test cases.

@mikaleppanen
Copy link
Author

@asifrizwanubx ok, thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2018

One note, this settings affects also boards that are for mbed 2 - 1k stack is not enough there (this was also identified in 7238 and its being changed currently - the solution is to provide non rtos stack size bigger, see the Pr #7238 for more details).

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 24, 2018

The unification still is in progress . We shall proceed with this one.

@ARMmbed/team-st-mcd Please review (affecting also other targets). When I look at some F4 targets, they set __ICFEDIT_size_cstack__ to 0x1000 . Besides the unification, happy with the values here?

@0xc0170 0xc0170 dismissed bulislaw’s stale review July 24, 2018 09:14

Updated to 1K

@bcostm
Copy link
Contributor

bcostm commented Jul 25, 2018

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2018

@bulislaw Final approval? As requested this was set to 1K. I am afraid this is not sufficient for mbed 2 (this board is supported there).

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 27, 2018

The unification PR is progressing, this should be good to go (1k stack defined for IAR there as well).

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 27, 2018

Build : SUCCESS

Build number : 2679
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7289/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 27, 2018

Test : SUCCESS

Build number : 2417
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7289/2417

@mbed-ci
Copy link

mbed-ci commented Jul 27, 2018

Exporter Build : SUCCESS

Build number : 2316
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7289/

@cmonr cmonr merged commit d65abb6 into ARMmbed:master Jul 31, 2018
@mikaleppanen mikaleppanen deleted the odin_iar_heap_inc branch August 1, 2018 09:11
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7289 from mikaleppanen/odin_iar_heap_inc
8e5b82d 
On STM32F439xI IAR linker file decreased stack size and increased heap
@jeromecoutant jeromecoutant mentioned this pull request Sep 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@asifrizwanubx asifrizwanubx asifrizwanubx approved these changes

@bcostm bcostm bcostm approved these changes

@bulislaw bulislaw bulislaw left review comments

Assignees
No one assigned
Labels
release-version: 5.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mikaleppanen @0xc0170 @bulislaw @asifrizwanubx @screamerbg @SeppoTakalo @bcostm @mbed-ci @cmonr