Skip to content

MBR: Fix issue with MBR init asserting on bad partition size #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

geky
Copy link
Contributor

@geky geky commented Jun 21, 2018

Description

With the assert, applications were unable to check the corrupted MBR and correct it, so invalid data on a block device would prevent an application from recovering.

cc @marcuschangarm, @dlfryar, @ARMmbed/mbed-os-storage

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2018

Build : SUCCESS

Build number : 2427
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7299/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@0xc0170 0xc0170 requested a review from a team June 22, 2018 08:24
@geky
Copy link
Contributor Author

geky commented Jun 25, 2018

Hey @dannybenor, @davidsaada, would one of you be able to review this pr. It's small but a part of the pr process.

@geky
Copy link
Contributor Author

geky commented Jun 25, 2018

@davidsaada Thanks!

@marcuschangarm
Copy link
Contributor

Thank you all! 🎉

@0xc0170 0xc0170 deleted the g-fix-mbr-invalid branch June 27, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants