Skip to content

Improve the process for Cortex-A9 in mbed_application #7331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2018
Merged

Improve the process for Cortex-A9 in mbed_application #7331

merged 1 commit into from
Jul 3, 2018

Conversation

TomoYamanaka
Copy link
Contributor

Description

I added the powerdown func by GIC in mbed_application because Cortex-A9 use GIC instead of NVIC.
This process prevent unexpected interrupt when updating software by using bootloader.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@TomoYamanaka
Improve the process for Cortex-A9 in mbed_application
9c99d7e 
I added the powerdown func by GIC in mbed_application because Cortex-A9 use GIC instead of NVIC.
This process prevent unexpected interrupt when updating software by using bootloader.
@0xc0170 0xc0170 requested a review from a team June 26, 2018 10:42
@cmonr cmonr requested a review from a team June 27, 2018 02:01
@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2018

Build : SUCCESS

Build number : 2455
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7331/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2018

Test : SUCCESS

Build number : 2232
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7331/2232

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2018

Exporter Build : SUCCESS

Build number : 2085
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7331/

@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

@ARMmbed/mbed-os-core ?

0xc0170
0xc0170 requested changes Jun 28, 2018
View reviewed changes
platform/mbed_application.c
void mbed_start_application(uintptr_t address)
{
__disable_irq();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use critical section instead please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c1728p9 Should be fine to be used here?

Copy link
Contributor Author

@TomoYamanaka TomoYamanaka Jul 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 @c1728p9
With respect to __disable_irq, it is used in this form at Cortex-M too. Ref
Should I change to critical section both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I was not aware. That will need to be addressed then separately if @c1728p9 agrees

@cmonr cmonr merged commit 7e0f75e into ARMmbed:master Jul 3, 2018
@TomoYamanaka TomoYamanaka deleted the improve_bootloader branch July 4, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomoYamanaka @cmonr @mbed-ci @0xc0170