Skip to content

LoRaWAN: Correcting doxygen #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2018
Merged

LoRaWAN: Correcting doxygen #7348

merged 3 commits into from
Jul 2, 2018

Conversation

hasnainvirk
Copy link
Contributor

Description

Use of MSG_FLAGS was updated in previous PRs but the doc was not updated
accordingly.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Target

Next patch release

Correcting doxygen
ce1e210 
Use of MSG_FLAGS was updated in previous PRs but the doc was not updated
accordingly.
@hasnainvirk
Copy link
Contributor Author

@0xc0170 @cmonr Please review.

@hasnainvirk hasnainvirk changed the title Correcting doxygen LoRaWAN: Correcting doxygen Jun 27, 2018
@0xc0170 0xc0170 requested a review from AnotherButler June 27, 2018 12:55
@adbridge adbridge requested a review from a team June 27, 2018 13:34
cmonr
cmonr previously approved these changes Jun 29, 2018
View reviewed changes
@hasnainvirk
Copy link
Contributor Author

@0xc0170 CI needed here.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2018

We will run as soon as docs team review (be aware that RC are going to be scheduled also soon).

@hasnainvirk
Copy link
Contributor Author

@0xc0170 It's a minor change. It should have been made with the corresponding PR, my mistake.
@peknis01 Can you please review to expedite the process ?

Copy edit LoRaWANinterface.h
563d742 
Copy edit for precise language and comma use.
Copy edit LoRaWANBase.h
aa53ee6 
Copy edit for precise language and comma use.
@cmonr cmonr requested a review from peknis01 June 30, 2018 01:13
@cmonr
Copy link
Contributor

cmonr commented Jun 30, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

Build : SUCCESS

Build number : 2484
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7348/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

Exporter Build : SUCCESS

Build number : 2123
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7348/

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

Test : SUCCESS

Build number : 2259
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7348/2259

@0xc0170 0xc0170 merged commit 3ee8f32 into ARMmbed:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

@peknis01 peknis01 Awaiting requested review from peknis01

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hasnainvirk @0xc0170 @cmonr @mbed-ci @AnotherButler