-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove semicolon at the end of #define #7355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Which code was erroring/failing before this fix? |
Worth referring to the specific SHA/pull request. I can't locate it on develop branch there. Seems still wrong to me. This should be fixed first upstream : https://github.com/ARM-software/CMSIS_5/blame/develop/CMSIS/RTOS2/RTX/Include/rtx_evr.h#L836 ? |
I sent upstream fix as I found these extra |
Upstream fixed (It was merged) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As now upstream is fixed, this will be in when we update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future please reference the upstream commit in the commit description.
/morph build |
Build : SUCCESSBuild number : 2469 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2098 |
I left the note in description "Note: Fix in CMSIS repo is present..." Not sure why grep on my local repo didn't show me semicolons in upstream (may be old copy / wrong command). Lesson learned will always check the web GitHub repo instead local repo. @0xc0170 - Thanks for adding PR to CMSIS. |
EventRecorder code, when disabling RTX specific events |
/morph export-build |
Exporter Build : FAILUREBuild number : 2101 |
Test : SUCCESSBuild number : 2246 |
/morph export-build |
Exporter Build : FAILUREBuild number : 2108 |
ಠ_ಠ /morph export-build |
Exporter Build : SUCCESSBuild number : 2111 |
I added the upstream fix to the merge commit msg |
Description
Remove semicolon followed by pre-processor defines. Noticed build failures when building code with "EVR_RTX_DISABLE" set.
Pull request type
Note: Fix in CMSIS repo is present.