Skip to content

Cellular: EasyCellularConnection::connect doesn't have any check that "CellularConnectionFSM" object is created or not #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2018

Conversation

mudassar-ublox
Copy link
Contributor

Description

EasyCellularConnection::connect doesn't have any check that "CellularConnectionFSM" object is created or not resulting into Hard Fault Handler. Instead of calling "_cellularConnectionFSM->set_sim_pin" method call "EasyCellularConnection::set_sim_pin" method. Which will create object of "CellularConnectionFSM" first, if not created already, and then set sim pin.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team June 28, 2018 07:31
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2468
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7359/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 28, 2018

Pipe closed.

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Jun 28, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 29, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Jun 29, 2018

/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Jun 29, 2018

/morph export-build

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Jun 29, 2018

/morph export-build

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 29, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2018

CI failure, restarting

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 29, 2018

@cmonr cmonr merged commit 58b725b into ARMmbed:master Jun 30, 2018
@0xc0170 0xc0170 removed the needs: CI label Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants