-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular: EasyCellularConnection::connect doesn't have any check that "CellularConnectionFSM" object is created or not #7359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : SUCCESSBuild number : 2468 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2097 |
/morph export-build |
/morph export-build |
Test : SUCCESSBuild number : 2245 |
/morph export-build |
/morph mbed2-build |
/morph export-build |
1 similar comment
/morph export-build |
/morph export-build |
Exporter Build : FAILUREBuild number : 2112 |
CI failure, restarting /morph export-build |
Exporter Build : SUCCESSBuild number : 2115 |
Description
EasyCellularConnection::connect doesn't have any check that "CellularConnectionFSM" object is created or not resulting into Hard Fault Handler. Instead of calling "_cellularConnectionFSM->set_sim_pin" method call "EasyCellularConnection::set_sim_pin" method. Which will create object of "CellularConnectionFSM" first, if not created already, and then set sim pin.
Pull request type