-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32 : get serial RX/TX active state #7361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit msg is STM32 serial RX/TX active patch
Should the second paragraph contain the info from description? It's small change but to me that description made it clear what is changing here
/morph build |
Build : SUCCESSBuild number : 2470 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2099 |
@jeromecoutant Looks like the astyle PR has caused this to need a rebase. |
In serial_tx_active and serial_rx_active functions, we check the internal state value with HAL_UART_STATE_BUSY_TX = 0x21U, HAL_UART_STATE_BUSY_RX = 0x22U, It seems that value can also be : HAL_UART_STATE_BUSY_TX_RX = 0x23U,
Rebase done |
/morph build |
Build : SUCCESSBuild number : 2473 Triggering tests/morph test |
Test : FAILUREBuild number : 2247 |
Exporter Build : SUCCESSBuild number : 2104 |
#7361 (comment) This was from the first build. Ignore. |
Test : SUCCESSBuild number : 2250 |
Description
We don't report any real issue yet, patch is proposed thanks to some code review.
In serial_tx_active and serial_rx_active functions,
we check the internal state value with
HAL_UART_STATE_BUSY_TX = 0x21U,
HAL_UART_STATE_BUSY_RX = 0x22U,
It seems that value can also be :
HAL_UART_STATE_BUSY_TX_RX = 0x23U,
Pull request type