Skip to content

STM32 : get serial RX/TX active state #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Description

We don't report any real issue yet, patch is proposed thanks to some code review.

In serial_tx_active and serial_rx_active functions,
we check the internal state value with

HAL_UART_STATE_BUSY_TX = 0x21U,
HAL_UART_STATE_BUSY_RX = 0x22U,

It seems that value can also be :
HAL_UART_STATE_BUSY_TX_RX = 0x23U,

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team June 28, 2018 10:07
LMESTM
LMESTM previously approved these changes Jun 28, 2018
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit msg is STM32 serial RX/TX active patch

Should the second paragraph contain the info from description? It's small change but to me that description made it clear what is changing here

0xc0170
0xc0170 previously approved these changes Jun 28, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2018

/morph build

bcostm
bcostm previously approved these changes Jun 28, 2018
@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2470
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7361/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 28, 2018

@jeromecoutant Looks like the astyle PR has caused this to need a rebase.

In serial_tx_active and serial_rx_active functions,
we check the internal state value with

HAL_UART_STATE_BUSY_TX = 0x21U,
HAL_UART_STATE_BUSY_RX = 0x22U,

It seems that value can also be :
HAL_UART_STATE_BUSY_TX_RX = 0x23U,
@jeromecoutant
Copy link
Collaborator Author

Rebase done

@cmonr
Copy link
Contributor

cmonr commented Jun 28, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2473
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7361/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 28, 2018

#7361 (comment) This was from the first build. Ignore.

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@cmonr cmonr merged commit 615d29e into ARMmbed:master Jun 29, 2018
@jeromecoutant jeromecoutant deleted the PR_SERIAL branch June 29, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants