Skip to content

Fix race condition in serial_api.c for NRF52 series #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2018
Merged

Fix race condition in serial_api.c for NRF52 series #7369

merged 2 commits into from
Jul 2, 2018

Conversation

marcuschangarm
Copy link
Contributor

Description

  • Elevate RTC2 interrupt priority to same level as UARTE to prevent race condition on shared variables.
  • Remove unused TXDRDY event code.
  • Fix typo in macro.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Marcus Chang added 2 commits June 28, 2018 16:36
Fix race condition in serial_api.c for NRF52 series
fc087ab 
* Elevate RTC2 interrupt priority to same level as UARTE to prevent
race condition on shared variables.
* Remove unused TXDRDY event code.
* Fix typo in macro.
Fix typo in NRF52 series README.md
2d71866 
UART configuration parameters mispelled.
@marcuschangarm
Copy link
Contributor Author

@cmonr 😛

@cmonr cmonr requested review from 0xc0170 and kjbracey June 29, 2018 00:41
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2018

How was this found and shall be tested?

@marcuschangarm
Copy link
Contributor Author

How was this found and shall be tested?

I'm using the network stress test to download 160 KiB data repeatedly over UART and ESP8266. When testing this PR: #7323 I noticed some new behavior.

@marcuschangarm marcuschangarm mentioned this pull request Jun 29, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Jun 30, 2018

@OPpuolitaival Might be worth looking into @marcuschangarm's test.

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

Build : SUCCESS

Build number : 2488
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7369/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

Exporter Build : SUCCESS

Build number : 2127
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7369/

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

Test : SUCCESS

Build number : 2263
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7369/2263

@0xc0170 0xc0170 merged commit 44acaf5 into ARMmbed:master Jul 2, 2018
This was referenced Jul 6, 2018
Closed
Closed
@marcuschangarm marcuschangarm deleted the fix-nrf52-serial branch July 9, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcuschangarm @0xc0170 @cmonr @mbed-ci @kjbracey