Skip to content

Cellular: fix greentea tests C027 and BG96 #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2018
Merged

Cellular: fix greentea tests C027 and BG96 #7374

merged 1 commit into from
Aug 2, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Jun 29, 2018 •
edited
Loading

Description

  • Fixed greentea tests for UBLOX C027 and Quectel BG96.
  • SIM test was fixed by adding additional waiting between commands or command might return sim busy
  • Fixed device specific test variations in network and power tests. Fixes to both defects. Some modems don't support command and fixed to take that into account.
  • Power test at timeout was increased as it might take more time than 1s.

No code changes, only test.

Internal ref to defect: IOTCELL-1139
Internal ref to defect: IOTCELL-1140

@mirelachirica please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team June 29, 2018 10:48
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2018

Internal ref to defect: IOTCELL-1139
Internal ref to defect: IOTCELL-1140

I assume those defects contain info that is not in the commit msg. I expect commit msg state how is this fixing those tests - at least short introduction to the changeset - what is wait(1) fixing and some other changes there.

There are two bugs but one commit fixing both? in two files?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2018

Reference https://os.mbed.com/docs/latest/reference/workflow.html - Guidelines for GitHub pull requests

@0xc0170 0xc0170 changed the title Cellular: fixed greentea tests C027 and BG96. Cellular: fix greentea tests C027 and BG96 Jul 2, 2018
@cmonr
Copy link
Contributor

cmonr commented Jul 5, 2018

@ARMmbed/mbed-os-wan Mind taking a look?

@cmonr
Copy link
Contributor

cmonr commented Jul 23, 2018

@ARMmbed/mbed-os-wan Ping

@cmonr
Copy link
Contributor

cmonr commented Jul 30, 2018

Anyone from @ARMmbed/mbed-os-wan in the office?

@jarvte jarvte force-pushed the fix_cellular_greentea branch from 88337b6 to 2e62f1b Compare August 1, 2018 11:42
cmonr
cmonr reviewed Aug 1, 2018
View reviewed changes
features/cellular/TESTS/api/cellular_power/main.cpp
err = pwr->opt_receive_period(0, CellularPower::EDRXEUTRAN_NB_S1_mode, 3);
TEST_ASSERT(err == NSAPI_ERROR_OK || err == NSAPI_ERROR_DEVICE_ERROR);
if (err == NSAPI_ERROR_DEVICE_ERROR) {
if (!(strcmp(devi, "TELIT_HE910") == 0 || strcmp(devi, "QUECTEL_BG96") == 0)) { // TELIT_HE910 and QUECTEL_BG96 just gives an error and no specific error number so we can't know is this real error or that modem/network does not support the command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate.

@cmonr
Copy link
Contributor

cmonr commented Aug 1, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2018

Build : SUCCESS

Build number : 2716
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7374/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2018

Exporter Build : SUCCESS

Build number : 2350
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7374/

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2018

Test : SUCCESS

Build number : 2448
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7374/2448

@cmonr
Copy link
Contributor

cmonr commented Aug 1, 2018

Looks like tihs needs a rebase.

@jarvte jarvte force-pushed the fix_cellular_greentea branch from 2e62f1b to b761e7b Compare August 2, 2018 08:48
@jarvte
Copy link
Contributor Author

jarvte commented Aug 2, 2018

@cmonr rebase done and tested greentea tests.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2018

Build : SUCCESS

Build number : 2722
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7374/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2018

Exporter Build : SUCCESS

Build number : 2358
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7374/

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2018

Test : SUCCESS

Build number : 2454
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7374/2454

@cmonr cmonr merged commit 2261ad2 into ARMmbed:master Aug 2, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7374 from jarvte/fix_cellular_greentea
ace6d96 
Cellular: fix greentea tests C027 and BG96
@jarvte jarvte deleted the fix_cellular_greentea branch October 22, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jarvte @0xc0170 @cmonr @mbed-ci @AriParkkila