Fix us_ticker & gpio bug #7385
Fix us_ticker & gpio bug #7385
Conversation
dualtime : modified about Interrupt callback function check error for winetinterface gpio : modified initialize function
| GPIOx->INTTYPECLR = 0xFFFF; | ||
| //GPIOx->INTPOLSET = 0x0000; | ||
| GPIOx->INTTYPESET = 0x0000; | ||
| //GPIOx->INTTYPECLR = 0xFFFF; |
There was a problem hiding this comment.
Please remove this commented out code
| //A170223 becky | ||
| assert_param(IS_GPIO_PIN(GPIO_InitStruct->GPIO_Mode)); | ||
| //////////////////////////////////////////////////////////// | ||
| assert_param(IS_GPIO_PUPD(GPIO_InitStruct->GPIO_PuPd)); |
| { | ||
| px_pcr->Port[pinpos] &= ~(Px_PCR_OD); | ||
| } | ||
| //if(GPIO_InitStruct->GPIO_Pad & Px_PCR_OD) |
There was a problem hiding this comment.
also remove this code (a reason shall be written in the commit msg why is this being removed)
|
I did change about your comment. |
|
@khj098765 Thanks for addressing the comments. Would you mind splitting up the first commit such that each bug fix is a single commit? It makes things simpler in case we need to revert something in the future. |
|
@cmonr |
|
@khj098765 You can, but the process can be a bit intimidating if you're not use to using some of the more advanced features of git. This changeset doesn't look too large. If you like, you can open a new PR, with the changes requested, and we can close this one. |
|
There are multiple ways to go about splitting a commit. A quick search pointed me to this particular one that explains the process fairly well: https://stackoverflow.com/questions/1440050/how-to-split-last-commit-into-two-in-git/1440200#1440200 |
|
I changed another pull request |
for greenteatest
dualtime : modified about Interrupt callback function check error
for winetinterface
gpio : modified initialize function
Description
Fix problems that could critical section along with adding tests to verify this behavior is fixed.
Tested locally with two targets and all toolchains.
You can see test results link
Pull request type