Skip to content

Fix target definition for NRF52 series #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Fix target definition for NRF52 series #7405

merged 1 commit into from
Jul 5, 2018

Conversation

marcuschangarm
Copy link
Contributor

Description

  • Removed RTC, NRF52840 doesn't support RTC API.
  • Reorganized DEVICE_HAS order for NRF52832.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

 * Removed RTC, NRF52840 doesn't support RTC API.
 * Reorganized DEVICE_HAS order for NRF52832.
@cmonr cmonr requested review from pan- and donatieng July 3, 2018 00:44
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come RTC did not error if it was not supported? fallback to lp ticker?

@marcuschangarm
Copy link
Contributor Author

How come RTC did not error if it was not supported? fallback to lp ticker?

The NRF52840_DK is not part of CI testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2525
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7405/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@cmonr cmonr merged commit 917dc83 into ARMmbed:master Jul 5, 2018
@marcuschangarm marcuschangarm deleted the fix-nrf52-target branch July 9, 2018 21:12
@0Grit
Copy link

0Grit commented Jul 13, 2018

@marcuschangarm

The NRF52840_DK is not part of CI testing.

What is the holdup on making the 'PDK' Mbed official?
We still are having issues using daplink with it since it's not technically supported.

@marcuschangarm
Copy link
Contributor Author

@studavekar

@cmonr
Copy link
Contributor

cmonr commented Jul 13, 2018

@loverdeg-ep Fyi, I would suggest y'all create an issue since coments that appears on closed PRs receive little attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants