Skip to content

Modified Wiced drivers EMAC instance get #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Modified Wiced drivers EMAC instance get #7413

merged 1 commit into from
Jul 5, 2018

Conversation

mikaleppanen
Copy link

@mikaleppanen mikaleppanen commented Jul 4, 2018

Description

Removed EMAC get_default_instance() since WLAN drivers are not default EMAC drivers. Moved EMAC static declaration inside get_instance().

Changes has been tested using ip-core nightly Jenkins jobs.

Fixes #7372

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Removed EMAC get_default_instance() since WLAN drivers are not default EMAC drivers.
Moved EMAC static declaration inside get_instance().
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

cc @pan

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph build

@0xc0170 0xc0170 requested a review from KariHaapalehto July 4, 2018 07:30
@mikaleppanen
Copy link
Author

@0xc0170 Kari is on vacation. @kjbracey-arm Please review this.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2523
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7413/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is more bearable.

+------------------+-------+-------+------+
| Module           | .text | .data | .bss |
+------------------+-------+-------+------+
| [fill]           |   100 |     4 |   21 |
| [lib]\c.a        | 25093 |  2472 |   89 |
| [lib]\gcc.a      |  3168 |     0 |    0 |
| [lib]\misc       |   252 |    16 |   28 |
| main.o           |    31 |     0 |    0 |
| mbed-os\drivers  |   192 |     4 |  100 |
| mbed-os\features |   204 |    12 |   48 |
| mbed-os\hal      |  1653 |     4 |   68 |
| mbed-os\platform |  2764 |   260 |  133 |
| mbed-os\rtos     |  9337 |   168 | 6073 |
| mbed-os\targets  |  7328 |     4 |  428 |
| Subtotals        | 50122 |  2944 | 6988 |
+------------------+-------+-------+------+

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2527
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7413/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@cmonr cmonr merged commit 4942ec5 into ARMmbed:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants