Skip to content

Separate version header file in Mbed OS #7434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2018
Merged

Separate version header file in Mbed OS #7434

merged 1 commit into from
Jul 13, 2018

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Jul 6, 2018 •
edited
Loading

Description

Separate version header file to have version details in Mbed OS source.
Update System stats to fetch Mbed OS version.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

CC @adbridge @bulislaw

@cmonr cmonr requested review from 0xc0170, kjbracey and adbridge July 6, 2018 16:15
@adbridge
Copy link
Contributor

adbridge commented Jul 6, 2018

@deepikabhavnani These are 2 separate changes, albeit related. Please split into 2 PRs.

@deepikabhavnani deepikabhavnani changed the title Add version header file and update system stats Separate version header file to have version details in Mbed OS source. Jul 6, 2018
@deepikabhavnani deepikabhavnani changed the title Separate version header file to have version details in Mbed OS source. Separate version header file in Mbed OS Jul 6, 2018
@deepikabhavnani deepikabhavnani mentioned this pull request Jul 6, 2018
Merged
adbridge
adbridge requested changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, however when referencing macro parameters they should always have ( ) around them:
MBED_STATIC_ASSERT((MBED_VERSION >= MBED_ENCODE_VERSION(M,m,p))

M, m and p should be (M), (m) and (p)

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Jul 6, 2018 •
edited
Loading

M, m and p should be (M), (m) and (p)

👍 Done

@deepikabhavnani
Copy link
Author

Related: #4891

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2018

151515

Why was this number chosen for master? we might get there one day or not?

👍 for having separate version header file

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Jul 9, 2018 •
edited
Loading

Why was this number chosen for master? we might get there one day or not?

We didn;t wanted default to be zero or empty defines, hence 0xF. But now I feel we can have it as 999999 as well..
@adbridge @0xc0170 - 999999 as default for master branch will be good?

@adbridge
Copy link
Contributor

adbridge commented Jul 9, 2018

I'd be surprised if we ever get to a major version of 15 considering the major (no pun intended) changes involved in bumping that field! Though the actual number is irrelevant really. Perhaps 999999 might be better...

@deepikabhavnani
Copy link
Author

Changed default version to 999999

@adbridge
Copy link
Contributor

LGTM

@0xc0170 0xc0170 requested a review from bulislaw July 10, 2018 14:48
@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

@bulislaw @kjbracey-arm Thoughts?

bulislaw
bulislaw reviewed Jul 11, 2018
View reviewed changes
platform/mbed_version.h Outdated
* @note: Version of master branch will be 999999 as default, hence no assert/warning is provided for
* master branch code
*/
#define MBED_VERSION_CHECK(M,m,p) do { \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the parameters to full spelled out version lik in MBED_ENCODE_VERSION

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2018

Build : SUCCESS

Build number : 2582
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7434/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2018

Exporter Build : SUCCESS

Build number : 2224
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7434/

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2018

Test : SUCCESS

Build number : 2334
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7434/2334

@cmonr cmonr merged commit 6fcb77e into ARMmbed:master Jul 13, 2018
@deepikabhavnani deepikabhavnani deleted the version_header branch July 13, 2018 17:59
@deepikabhavnani deepikabhavnani mentioned this pull request Jul 18, 2018
Closed
@cmonr cmonr mentioned this pull request Aug 3, 2018
Closed
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7434 from deepikabhavnani/version_header
3d1876b 
Separate version header file in Mbed OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deepikabhavnani @adbridge @0xc0170 @cmonr @mbed-ci @bulislaw