Skip to content

Recognize ".cc" and ".hh" source file extensions #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Conversation

snej
Copy link
Contributor

@snej snej commented Jul 6, 2018

Description

Minor change to the Python mbedToolchain class to recognize the commonly used filename extensions ".cc" (C++ source code) and ".hh" (C++ header). Without this change, source code with this naming convention (e.g. my company's entire sourcebase) is ignored by the CLI.

Tested by building a project containing source code with such filename suffixes.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

".cc" --> C++ source code
".hh" --> header

This change allows existing source code with this naming
convention (e.g. my company's) to be used in mbed.os projects.
@0xc0170 0xc0170 requested a review from a team July 9, 2018 08:02
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Jul 9, 2018

@theotherjimmy Any objections?

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to rebase my refactor-resources pr when this goes in, or you'll have to rebase this.

@cmonr
Copy link
Contributor

cmonr commented Jul 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2018

Build : SUCCESS

Build number : 2553
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7437/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2018

@cmonr
Copy link
Contributor

cmonr commented Jul 10, 2018

/morph mbed2-build

@0xc0170 0xc0170 merged commit 61f3d8b into ARMmbed:master Jul 10, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2018

@snej Thanks for the contribution

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Recognize ".cc" and ".hh" source file extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants